Fix integer overflow on 32-bit architectures #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On 32-bit architectures (such as OpenBSD ARM, Linux ARM, etc.), building the parser fails with integer overflow errors:
The issue occurs because:
inttype is 32-bit on 32-bit architecturesintcannot hold 64-bit values likemath.MaxInt64Solution
This PR changes the affected types from
inttoint64:lPosandrPosvariables frominttoint64to accommodatemath.MaxInt64EncodeFlagstype frominttoint64to support large bit shift operationsFmtFlagstype frominttoint64for the same reasonTesting
Successfully built and tested on:
GOOS=openbsd GOARCH=arm(32-bit)The changes are backward compatible since
int64is a superset ofinton all platforms.Impact