Converting Metal Sheets into Plasteel Sheets.

[cm13-issue-bot]

Testmerges

#10999: '[DNM] Fix of various plane related issues' by Blundir at commit f85a7153c4
#11075: 'Ticket Panel (Adminhelps & Mentorhelps)' by GeneriedJenelle at commit 4ad8d0cf87
#11902: 'implement pii scrubbing for sentry' by hry-gh at commit 759efb7bd1
#12174: 'Yautja Armor Sets' by realforest2001 at commit 90c66798ed
#10414: 'Port: Harm Intent uses Auto-Fire instead of PB + Misc' by MistChristmas at commit 5a14e49a6e
#11161: 'Gas trap buff & neuro smoke tweaks' by Diegoflores31 at commit 92b29e6eb0
#12361: 'pride scarfs in loadout' by Detective-Google at commit 6ddcf88cb8
#12322: 'Fort McNeil - (Lowpop) Ground Map' by Steelpoint at commit ce3292659b
#12408: 'Fix: Egg Morphers are whackable + Get some extra health' by MistChristmas at commit e1e480a266
#9405: '[EVENT][s][IDB IGNORE] Pathogen Confluence' by realforest2001 at commit 645909c545

Round ID

34664

Description of the bug

While removing some upgraded plasteel cades (e.g. acid proofed cades) to change what upgrade they had, i realised i was getting 8 plasteel sheets back instead of 6 plasteel sheets 2 metal sheets. I don't think it is suppose to be this way, it would be a slow but effective way of converting metal sheets into plasteel sheets.

What's the difference with what should have happened?

I expected to get 6 plasteel sheets and 2 metal sheets, plus barbed wire if applied, from deconstructing a upgraded plasteel cade. Instead i got 8 plasteel sheets back, and barbed wire if applied, but no metal sheets.

How do we reproduce this bug?

1. Keep an eye on your plasteel sheet count.
2. Build a normal, non-folding, plasteel cade.
3. Upgrade it using 2 metal sheets, any upgrade works for this bug.
4. Deconstruct the upgraded plasteel cade, by using a Screwdriver Wrench Crowbar.
5. Collect the plasteel sheets from the deconstruction which should land you with 8 plasteel sheets, and no metal sheets, from something that costed 6 plasteel sheets 2 metal sheets to build.

Attached logs

Uhhh, i don't precisely know what logs to paste here?

Additional details

• Author: Gnu47
• Admin: the novacypher
• Note: None

[LatoDiafol]

Should be fixed by: #12453

The issue was caused by the barricade class simply adding up to two sheets of "stack material" during disassembly and not handling the case of the upgrade and stack materials being different.