Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBSAN][GEMDigi] shift exponent is too large for int #46580

Open
smuzaffar opened this issue Nov 1, 2024 · 5 comments
Open

[UBSAN][GEMDigi] shift exponent is too large for int #46580

smuzaffar opened this issue Nov 1, 2024 · 5 comments

Comments

@smuzaffar
Copy link
Contributor

UBSAN IBs report many runtime errors like [a]. The stack at the time of error is [b]. The call is triggered from https://github.com/cms-sw/cmssw/blob/master/EventFilter/GEMRawToDigi/plugins/GEMDigiToRawModule.cc#L204 which was add in #38062 . Such errors normally shows that there might be some logical errors.

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/ubsan_logs/CMSSW_14_2_X_2024-10-30-2300/logs/a4/a46e3025fea17bb12e2d7f9cf63e862f/log

10007.0/step2:DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 3951 is too large for 32-bit type 'int'
10026.0/step2:DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 3615 is too large for 32-bit type 'int'
10224.0/step2:DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 2424 is too large for 32-bit type 'int'
10224.15/step2:DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 3944 is too large for 32-bit type 'int'
10225.0/step2:DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 1740 is too large for 32-bit type 'int'
10424.0/step2:DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 3944 is too large for 32-bit type 'int'
10809.0/step2:DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 1759 is too large for 32-bit type 'int'
10842.0/step2:DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 2651 is too large for 32-bit type 'int'

[b] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_14_2_UBSAN_X_2024-10-30-2300/pyRelValMatrixLogs/run/10007.0_SingleMuPt10+2017/step2_SingleMuPt10+2017.log#/41-41

src/DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151:38: runtime error: shift exponent 3951 is too large for 32-bit type 'int'
    #0 0x1536313b5e86 in GEMOptoHybrid::addVFAT(GEMVFAT) src/DataFormats/GEMDigi/interface/GEMOptoHybrid.h:151
    #1 0x1536313b5e86 in GEMDigiToRawModule::produce(edm::StreamID, edm::Event&, edm::EventSetup const&) const src/EventFilter/GEMRawToDigi/plugins/GEMDigiToRawModule.cc:204
    #2 0x153715b6d0fd in edm::global::EDProducerBase::doEvent(edm::EventTransitionInfo const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) src/FWCore/Framework/src/global/EDProducerBase.cc:69
    #3 0x153715b1dd58 in edm::WorkerT<edm::global::EDProducerBase>::implDo(edm::EventTransitionInfo const&, edm::ModuleCallingContext const*) src/FWCore/Framework/src/WorkerT.cc:202
    #4 0x15371515934f in edm::workerhelper::CallImpl<edm::OccurrenceTraits<edm::EventPrincipal, (edm::BranchActionType)1> >::call(edm::Worker*, edm::StreamID, edm::EventTransitionInfo const&, edm::ActivityRegistry*, 
@smuzaffar
Copy link
Contributor Author

assign reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

New categories assigned: reconstruction

@jfernan2,@mandrenguyen you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar
Copy link
Contributor Author

FYI @yeckang

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

A new Issue was created by @smuzaffar.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar smuzaffar changed the title [UBSAN][GEMDigi] shift exponent 3951 is too large for int [UBSAN][GEMDigi] shift exponent is too large for int Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants