Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase-2 Calo: e/g standalone emulator & related objects #1139

Open
cerminar opened this issue Jun 19, 2023 · 0 comments
Open

Phase-2 Calo: e/g standalone emulator & related objects #1139

cerminar opened this issue Jun 19, 2023 · 0 comments
Labels
Emulator Development Emulator development PR Event Content Anything to do with the content of events in the EDM framework Phase-2 Pertains to phase-2 development

Comments

@cerminar
Copy link

Following the discussion we had during the integration of PR #1069, I report here a few comments that I expressed in that occasion:

  1. The 3 "digitized" classes only persist an integer. Therefore, it would be more convenient to store them within the corresponding CMSSW object to ease their access by downstream consumers.
  • The DigitizedClusterGT objects should become a data member of the CaloCrystalCluster or the Egamma objects (most likely the second since we will need a digitized word also for the HGC sector).
  • Same goes for the DigitizedClusterCorrelator and DigitizedTowerCorrelator, which should become data members of the CaloTower objects.
  1. We need to add the quality bits to the DigitizedClusterGT; otherwise, they can not be consumed by either the GT nor the Correlator emulators

  2. We need to establish a link between Egamma and CaloCrystalCluster, possibly via an edm::Ptr<L1Candidate>. This would allow doing the same with the HGC multiclusters once added to the emulator.

@aloeliger aloeliger added Phase-2 Pertains to phase-2 development Emulator Development Emulator development PR Event Content Anything to do with the content of events in the EDM framework labels Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emulator Development Emulator development PR Event Content Anything to do with the content of events in the EDM framework Phase-2 Pertains to phase-2 development
Projects
None yet
Development

No branches or pull requests

2 participants