Make QuestionActionHandler an abstract class

Author: prandla

cms/server/admin/handlers/contestquestion.py

@@ -25,6 +25,7 @@
 
 """
 
+from abc import ABCMeta, abstractmethod
 import logging
 
 import collections
@@ -65,10 +66,11 @@ def get(self, contest_id):
 
 
 
-class QuestionActionHandler(BaseHandler):
+class QuestionActionHandler(BaseHandler, metaclass=ABCMeta):
     """Base class for handlers for actions on questions."""
 
-    def do(self, question: Question):
+    @abstractmethod
+    def process_question(self, question: Question):
         """Called on POST requests. Perform the appropriate action on the
         question."""
         pass
@@ -88,15 +90,15 @@ def post(self, contest_id, question_id):
         if self.contest is not question.participation.contest:
             raise tornado_web.HTTPError(404)
 
-        self.do(question)
+        self.process_question(question)
         self.redirect(ref)
 
 class QuestionReplyHandler(QuestionActionHandler):
     """Called when the manager replies to a question made by a user.
 
     """
 
-    def do(self, question):
+    def process_question(self, question):
         reply_subject_code: str = self.get_argument(
             "reply_question_quick_answer", "")
         question.reply_text = self.get_argument("reply_question_text", "")
@@ -125,7 +127,7 @@ class QuestionIgnoreHandler(QuestionActionHandler):
     question.
 
     """
-    def do(self, question):
+    def process_question(self, question):
         should_ignore = self.get_argument("ignore", "no") == "yes"
 
         # Commit the change.
@@ -143,7 +145,7 @@ def do(self, question):
 class QuestionClaimHandler(QuestionActionHandler):
     """Called when the manager chooses to claim or unclaim a question."""
 
-    def do(self, question):
+    def process_question(self, question):
         # Can claim/unclaim only a question not ignored or answered.
         if question.ignored or question.reply_timestamp is not None:
             raise tornado_web.HTTPError(405)