Fix crash

killerwife · killerwife · commit b157da400f48 · 2024-11-14T16:37:21.000+01:00
diff --git a/src/game/BattleGround/BattleGroundMgr.h b/src/game/BattleGround/BattleGroundMgr.h
@@ -61,7 +61,7 @@ class BattleGroundMgr
 
         uint32 CreateBattleGround(BattleGroundTypeId /*bgTypeId*/, uint32 /*minPlayersPerTeam*/, uint32 /*maxPlayersPerTeam*/, uint32 /*levelMin*/, uint32 /*levelMax*/, char const* /*battleGroundName*/, uint32 /*mapId*/, float /*team1StartLocX*/, float /*team1StartLocY*/, float /*team1StartLocZ*/, float /*team1StartLocO*/, float /*team2StartLocX*/, float /*team2StartLocY*/, float /*team2StartLocZ*/, float /*team2StartLocO*/, float /*startMaxDist*/, uint32 /*playerSkinReflootId*/);
 
-        void AddBattleGround(uint32 instanceId, BattleGroundTypeId bgTypeId, BattleGround* bg);;
+        void AddBattleGround(uint32 instanceId, BattleGroundTypeId bgTypeId, BattleGround* bg);
         void RemoveBattleGround(uint32 instanceId, BattleGroundTypeId bgTypeId) { m_battleGrounds[bgTypeId].erase(instanceId); }
 
         void CreateInitialBattleGrounds();
diff --git a/src/game/Maps/Map.cpp b/src/game/Maps/Map.cpp
@@ -2055,6 +2055,9 @@ void BattleGroundMap::Update(const uint32& diff)
 {
     Map::Update(diff);
 
+    if (!m_bg)
+        return;
+
     if (!m_bg->GetPlayersSize())
     {
         // BG is empty

Original file line number	Diff line number	Diff line change
`@@ -2055,6 +2055,9 @@ void BattleGroundMap::Update(const uint32& diff)`
`2055`	`2055`	`{`
`2056`	`2056`	`Map::Update(diff);`
`2057`	`2057`
	`2058`	`+ if (!m_bg)`
	`2059`	`+ return;`
	`2060`	`+`
`2058`	`2061`	`if (!m_bg->GetPlayersSize())`
`2059`	`2062`	`{`
`2060`	`2063`	`// BG is empty`