Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support promise cancellation #158

Open
clue opened this issue Aug 24, 2024 · 0 comments
Open

Support promise cancellation #158

clue opened this issue Aug 24, 2024 · 0 comments

Comments

@clue
Copy link
Owner

clue commented Aug 24, 2024

We should register a Promise cancellation handler so that the following code actually cleans up the underlying promise and socket resources as applicable:

$promise = $redis->blpop('list', 100);

$promise->cancel();

See reactphp/dns#28 and many others

@clue clue added this to the v3.0.0 milestone Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant