Update openstack client to handle merging openstack config between blueprint inputs and openstack env variables

Author: Mohammed AbuAisha

CHANGELOG.txt

@@ -1,3 +1,5 @@
+2.7.3:
+    - Resolve issue with merging openstack config
 2.7.2:
     - Allow openstack_config keys to be empty, in case these values are taken from `openstack-config.json`.
     - Fix bug where key type runtime properties were incorrectly assigned.

openstack_plugin_common/__init__.py

@@ -613,14 +613,34 @@ class OpenStackClient(object):
         COMMON | {'project_id', 'project_name', 'user_domain_name'},
         COMMON | {'project_name', 'user_domain_name', 'project_domain_name'},
     ]
+
+    NON_AUTH_ITEMS = ['region', 'insecure',
+                      'ca_cert', 'nova_url',
+                      'neutron_url', 'custom_configuration', 'logging']
+
     OPTIONAL_AUTH_PARAMS = {AUTH_PARAM_INSECURE, AUTH_PARM_CA_CERT}
 
     def __init__(self, client_name, client_class, config=None, *args, **kw):
         cfg = Config.get()
-
         if config:
             Config.update_config(cfg, config)
 
+            # This check to make sure that blueprint openstack config
+            # contains all the required auth params + any non-auth param
+            if set(config.keys())\
+                    in self.AUTH_SETS and config.keys() in self.NON_AUTH_ITEMS:
+
+                # Check if there is any value exists on ``cfg``
+                # that does not exist on ``config`` then these extra params
+                # should be removed to prevent any merging conflicts
+                removed_keys = []
+                for k, v in cfg.iteritems():
+                    if k not in config:
+                        removed_keys.append(k)
+
+                for key in removed_keys:
+                    del cfg[key]
+
         v3 = '/v3' in cfg['auth_url']
         # Newer libraries expect the region key to be `region_name`, not
         # `region`.

plugin.yaml

@@ -5,9 +5,9 @@
 plugins:
   openstack:
     executor: central_deployment_agent
-    source: https://github.com/cloudify-cosmo/cloudify-openstack-plugin/archive/2.7.2.zip
+    source: https://github.com/cloudify-cosmo/cloudify-openstack-plugin/archive/2.7.3.zip
     package_name: cloudify-openstack-plugin
-    package_version: '2.7.2'
+    package_version: '2.7.3'
 
 data_types:
   cloudify.openstack.types.custom_configuration:

setup.py

@@ -19,7 +19,7 @@
 setup(
     zip_safe=True,
     name='cloudify-openstack-plugin',
-    version='2.7.2',
+    version='2.7.3',
     author='Cloudify',
     author_email='[email protected]',
     packages=[