fix flake8

fix issue

fix from pr

another fix

fix another something

trying that

fix another izsue

fix another

Author: earthmant

CHANGELOG.txt

@@ -1,3 +1,7 @@
+3.2.17: Support no networks.
+3.2.16:
+  - Update wagon builder to py2py3 wagon.
+  - Added 5.1.0 integration tests.
 3.2.14: Support Python 3.
 3.2.13:
   - Support quota operations on Project [ get_quota/update_quota ].

openstack_plugin/resources/compute/server.py

@@ -872,6 +872,22 @@ def _update_nics_config(server_config, client_config, allow_multiple=False):
     # valid only when one network created for the current tenant, the server
     # will attach automatically to that network
     if not (nics_from_node or nics_from_rels):
+        compute_api_version = client_config.get('compute_api_version')
+        compute_microversion = client_config.get(
+            'compute_default_microversion')
+        if compute_api_version:
+            compute_api_version = float(compute_api_version)
+        if compute_microversion:
+            compute_microversion = float(compute_microversion)
+        if any([compute_api_version >= 2.37, compute_microversion >= 2.37]):
+            ctx.logger.warn(
+                'No network was provided and no ports are connected '
+                'at server creation time. This is only supported for compute '
+                'API versions 2.37 and above. '
+                'Additionally, the network key should be set to \'none\' or '
+                '\'auto\'. The plugin default is \'none\'.')
+            server_config['networks'] = 'none'
+            ctx.instance.runtime_properties['networks'] = 'none'
         return
     # Try to merge them
     elif nics_from_node and nics_from_rels and not allow_multiple:
@@ -1486,6 +1502,8 @@ def _validate_external_volume_connection(openstack_resource):
 
 
 def _validate_security_groups_on_ports(server_networks, client_config):
+    if not isinstance(server_networks, list):
+        return
     for net in server_networks:
         if net.get('port'):
             port = OpenstackPort(client_config=client_config,

openstack_plugin/resources/network/port.py

@@ -394,7 +394,6 @@ def attach(openstack_resource, port_id):
                              device_id)
 
 
-
 @with_compat_node
 @with_openstack_resource(OpenstackServer)
 def detach(openstack_resource, port_id):
@@ -426,7 +425,6 @@ def create_server_interface(openstack_resource, port_id, **_):
     attachment.
     :param openstack_resource:
     :param port_id:
-    :param server_id:
     :return:
     """
     for interface_attachments in openstack_resource.server_interfaces():
@@ -443,7 +441,6 @@ def delete_server_interface(openstack_resource, port_id, **_):
     attachment.
     :param openstack_resource:
     :param port_id:
-    :param server_id:
     :return:
     """
     for interface_attachments in openstack_resource.server_interfaces():

plugin.yaml

@@ -1715,20 +1715,27 @@ relationships:
   # server is created, usually used if the server need to attached to multiple ports
   cloudify.relationships.openstack.port_connected_to_server:
     derived_from: cloudify.relationships.connected_to
-    source_interfaces:
+    target_interfaces:
       cloudify.interfaces.relationship_lifecycle:
         postconfigure:
           implementation: openstack.openstack_plugin.resources.network.port.create_server_interface
           inputs:
             port_id:
               default: { get_attribute: [ SOURCE, id ] }
+        unlink:
+          implementation: openstack.openstack_plugin.resources.network.port.delete_server_interface
+          inputs:
+            port_id:
+              default: { get_attribute: [ SOURCE, id ] }
+    source_interfaces:
+      cloudify.interfaces.relationship_lifecycle:
         establish:
-          implementation: openstack.openstack_plugin.resources.network.port.attach_to_server
+          implementation: openstack.openstack_plugin.resources.network.port.attach
           inputs:
             device_id:
               default: { get_attribute: [ TARGET, id ] }
         unlink:
-          implementation: openstack.openstack_plugin.resources.network.port.delete_server_interface
+          implementation: openstack.openstack_plugin.resources.network.port.detach
           inputs:
             port_id:
               default: { get_attribute: [ SOURCE, id ] }