Skip to content

Upgrade to golang.org/x/tools v0.39.0 to fix generation #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gururajsh merged 2 commits into from
Dec 1, 2025
Merged

Upgrade to golang.org/x/tools v0.39.0 to fix generation #3635

gururajsh merged 2 commits into from
Dec 1, 2025

Conversation

@marckhouzam
Copy link
Contributor

@marckhouzam marckhouzam commented Nov 20, 2025

Description of the Change

golang.org/x/tools v0.38.0 had broken the Counterfeiter code generation, so before this PR, if you run go generate ./... you will see errors like these:

$ go generate ./...
# github.com/maxbrunsfeld/counterfeiter/v6/generator
../../../../go/pkg/mod/github.com/maxbrunsfeld/counterfeiter/[email protected]/generator/import.go:45:17: undefined: imports.VendorlessPath
../../../../go/pkg/mod/github.com/maxbrunsfeld/counterfeiter/[email protected]/generator/import.go:75:29: undefined: imports.VendorlessPath
../../../../go/pkg/mod/github.com/maxbrunsfeld/counterfeiter/[email protected]/generator/loader.go:125:28: undefined: imports.VendorlessPath
[...]

This PR updates golang.org/x/tools to the fixed version v0.39.0.

Why Is This PR Valuable?

Fixed code generation

I'm not sure when the generated code is being used, but it is out of date. If it has value, I can push a different PR to update the generate fakes.

@marckhouzam marckhouzam mentioned this pull request Nov 20, 2025
Open
anujc25
anujc25 approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this. 👍

@marckhouzam marckhouzam mentioned this pull request Dec 1, 2025
Open
gururajsh
gururajsh approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit 8da618e into cloudfoundry:v8 Dec 1, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gururajsh gururajsh gururajsh approved these changes

+1 more reviewer

@anujc25 anujc25 anujc25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marckhouzam @anujc25 @gururajsh