From bdbba2f585f67b31924eacb06e048a043c2e1104 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Tue, 18 Nov 2025 14:46:28 -0500 Subject: [PATCH] Fix missing completion for the AppType 'cnb' Signed-off-by: Marc Khouzam --- command/flag/app_type.go | 2 +- command/flag/app_type_test.go | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/command/flag/app_type.go b/command/flag/app_type.go index 5b5fdfd4587..6a4eb3e9788 100644 --- a/command/flag/app_type.go +++ b/command/flag/app_type.go @@ -5,5 +5,5 @@ import flags "github.com/jessevdk/go-flags" type AppType string func (AppType) Complete(prefix string) []flags.Completion { - return completions([]string{"buildpack", "docker"}, prefix, false) + return completions([]string{"buildpack", "docker", "cnb"}, prefix, false) } diff --git a/command/flag/app_type_test.go b/command/flag/app_type_test.go index 017df82a186..cd1636e7fd2 100644 --- a/command/flag/app_type_test.go +++ b/command/flag/app_type_test.go @@ -19,14 +19,16 @@ var _ = Describe("AppType", func() { Entry("completes to 'buildpack' when passed 'b'", "b", []flags.Completion{{Item: "buildpack"}}), + Entry("completes to 'cnb' when passed 'c'", "c", + []flags.Completion{{Item: "cnb"}}), Entry("completes to 'docker' when passed 'd'", "d", []flags.Completion{{Item: "docker"}}), Entry("completes to 'buildpack' when passed 'bU'", "bU", []flags.Completion{{Item: "buildpack"}}), Entry("completes to 'docker' when passed 'Do'", "Do", []flags.Completion{{Item: "docker"}}), - Entry("returns 'buildpack' and 'docker' when passed nothing", "", - []flags.Completion{{Item: "buildpack"}, {Item: "docker"}}), + Entry("returns 'buildpack', 'cnb', and 'docker' when passed nothing", "", + []flags.Completion{{Item: "buildpack"}, {Item: "docker"}, {Item: "cnb"}}), Entry("completes to nothing when passed 'wut'", "wut", []flags.Completion{}), )