Skip to content

Commit ae4291a

Browse files
committed
Fix missing completion for 'SpaceSupporter'
Cherry-pick of #3627 Signed-off-by: Marc Khouzam <[email protected]>
1 parent 3a79eef commit ae4291a

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

command/flag/space_role.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type SpaceRole struct {
1111
}
1212

1313
func (SpaceRole) Complete(prefix string) []flags.Completion {
14-
return completions([]string{"SpaceManager", "SpaceDeveloper", "SpaceAuditor"}, prefix, false)
14+
return completions([]string{"SpaceManager", "SpaceDeveloper", "SpaceAuditor", "SpaceSupporter"}, prefix, false)
1515
}
1616

1717
func (s *SpaceRole) UnmarshalFlag(val string) error {

command/flag/space_role_test.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ var _ = Describe("SpaceRole", func() {
1616
completions := spaceRole.Complete(prefix)
1717
Expect(completions).To(Equal(matches))
1818
},
19-
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed 'S'", "S",
20-
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
21-
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed 's'", "s",
22-
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
19+
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed 'S'", "S",
20+
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
21+
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed 's'", "s",
22+
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
2323
Entry("completes to 'SpaceAuditor' when passed 'Spacea'", "Spacea",
2424
[]flags.Completion{{Item: "SpaceAuditor"}}),
2525
Entry("completes to 'SpaceDeveloper' when passed 'Spaced'", "Spaced",
@@ -28,8 +28,10 @@ var _ = Describe("SpaceRole", func() {
2828
[]flags.Completion{{Item: "SpaceManager"}}),
2929
Entry("completes to 'SpaceManager' when passed 'spacEM'", "spacEM",
3030
[]flags.Completion{{Item: "SpaceManager"}}),
31-
Entry("returns 'SpaceManager', 'SpaceDeveloper' and 'SpaceAuditor' when passed nothing", "",
32-
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}}),
31+
Entry("completes to 'SpaceSupporter' when passed 'Spaces'", "Spaces",
32+
[]flags.Completion{{Item: "SpaceSupporter"}}),
33+
Entry("returns 'SpaceManager', 'SpaceDeveloper', 'SpaceAuditor' and 'SpaceSupporter' when passed nothing", "",
34+
[]flags.Completion{{Item: "SpaceManager"}, {Item: "SpaceDeveloper"}, {Item: "SpaceAuditor"}, {Item: "SpaceSupporter"}}),
3335
Entry("completes to nothing when passed 'wut'", "wut",
3436
[]flags.Completion{}),
3537
)

0 commit comments

Comments
 (0)