allow void for this type (#246)

Signed-off-by: Kangrui Johann Ye <[email protected]>
cloudflightio · Oct 16, 2024 · 0a3f8ea · 0a3f8ea
1 parent 350f78d
commit 0a3f8ea
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin",
-    "version": "1.0.0-rc8",
+    "version": "1.0.0-rc9",
     "private": true,
     "volta": {
         "node": "20.12.2",

diff --git a/packages/eslint-plugin-angular/package.json b/packages/eslint-plugin-angular/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-angular",
-    "version": "1.0.0-rc8",
+    "version": "1.0.0-rc9",
     "description": "Cloudflight eslint-plugin & eslint-config for angular",
     "volta": {
         "extends": "../../package.json"

diff --git a/packages/eslint-plugin-node/package.json b/packages/eslint-plugin-node/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-node",
-    "version": "1.0.0-rc8",
+    "version": "1.0.0-rc9",
     "description": "Cloudflight eslint-plugin & eslint-config for node",
     "volta": {
         "extends": "../../package.json"

diff --git a/packages/eslint-plugin-react/package.json b/packages/eslint-plugin-react/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-react",
-    "version": "1.0.0-rc8",
+    "version": "1.0.0-rc9",
     "description": "Cloudflight eslint-plugin & eslint-config for React",
     "volta": {
         "extends": "../../package.json"

diff --git a/packages/eslint-plugin-typescript/package.json b/packages/eslint-plugin-typescript/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-typescript",
-    "version": "1.0.0-rc8",
+    "version": "1.0.0-rc9",
     "description": "Cloudflight eslint-plugin & eslint-config for typescript",
     "volta": {
         "extends": "../../package.json"

diff --git a/packages/eslint-plugin-typescript/src/configs/typescript-eslint.ts b/packages/eslint-plugin-typescript/src/configs/typescript-eslint.ts
@@ -20,7 +20,7 @@ export const typescriptEslintRules: TSESLint.Linter.RulesRecord = {
     [`${pluginPrefix}/no-inferrable-types`]: ['error', {ignoreParameters: true}],
     'no-invalid-this': 'off',
     [`${pluginPrefix}/no-invalid-this`]: ['error'],
-    [`${pluginPrefix}/no-invalid-void-type`]: ['error', {allowInGenericTypeArguments: true}],
+    [`${pluginPrefix}/no-invalid-void-type`]: ['error', {allowInGenericTypeArguments: true, allowAsThisParameter: true}],
     'no-restricted-imports': 'off',
     [`${pluginPrefix}/no-restricted-imports`]: ['error', {name: 'rxjs/Rx', message: "Please import directly from 'rxjs' instead"}],
     'no-shadow': 'off',

diff --git a/packages/eslint-plugin-vue/package.json b/packages/eslint-plugin-vue/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cloudflight/eslint-plugin-vue",
-    "version": "1.0.0-rc8",
+    "version": "1.0.0-rc9",
     "description": "Cloudflight eslint-plugin & eslint-config for vue",
     "volta": {
         "extends": "../../package.json"