-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wrangler deploy artifacts for deployment URLs #311
Labels
Comments
This is a bug where wrangler-action is picking up the first url listed in environment variables. We need to create a PR to use deployment metadata instead. Updating this issue to reflect what work needs to be done. |
nprogers
changed the title
Incorrect deployment URL set
Use wrangler deploy artifacts for deployment URLs
Nov 12, 2024
Southpaw1496
added a commit
to QuiltMC/quiltmc.org
that referenced
this issue
Nov 29, 2024
…)" This reverts commit fd8b3a5. The world wasn't ready (I think it's cloudflare/wrangler-action#311). [skip ci]
I still have this issue due to it extracts the first URL from stdout, which is verison:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi all,
I was wondering why I see some of my environment variables as deployment urls. I would argue that the coding here is not robust enough as I now always get, for example, the posthog endpoint I set as a variable (because it may be us or eu) as my deployment url:
wrangler-action/src/index.ts
Lines 343 to 349 in b2be7ab
Would be nice if this could be improved.
The text was updated successfully, but these errors were encountered: