perf(cloudflare): reuse response-stage invocations - #3388
Merged
Merged
Conversation
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Contributor
|
Contributor
Performance benchmarksCompared 1 improved · 0 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
Member
Author
|
/bigbonk review for issues Time limit: 8 minutes. Complete the review and post all findings within that limit. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
Cache hits no longer serialize a stored replay invocation. Cache misses no longer deep-clone props three times or serialize the same stored invocation twice.
Validation
vp test run tests/cloudflare-response-store-worker.test.ts(3 passed)vp test run tests/response-store-data.test.tsfrompackages/cloudflare(17 passed)vp check packages/cloudflare/src/cache/response-store-adapter.worker.ts tests/cloudflare-response-store-worker.test.tsvp run @vinext/cloudflare#buildgit diff --checkThis preserves Next.js-visible behavior and only changes Cloudflare adapter serialization work, so there is no corresponding Next.js test to port.