feat(build): run lifecycle through Vite by james-elicx · Pull Request #3377 · cloudflare/vinext

james-elicx · 2026-09-22T11:37:04Z

Summary

connect the shared lifecycle to full direct Vite CLI builds, including global options before the command
keep watch, targeted/SSR, ordinary programmatic, and nested Vite builds outside the top-level lifecycle
preserve configured prerender concurrency, resolved user plugins, custom output roots, and production semantics
isolate the auxiliary hybrid Pages bundle in its own named environment

Validation

Vite command contract and invocation tests
prerender configuration tests
vp check
vp run vinext#build

PR 3 of 7.

pkg-pr-new · 2026-09-22T11:38:05Z

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3377

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3377

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3377

vinext

npm i https://pkg.pr.new/vinext@3377

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3377

commit: a6bef91

james-elicx · 2026-09-22T11:38:36Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

github-actions · 2026-09-22T11:41:31Z

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original
response-store-demo	preview	production
workers-cache	preview	production
kv	preview	production
static-export	preview	production
web	preview	production

github-actions · 2026-09-22T11:42:05Z

Performance benchmarks

Compared a6bef91 against base 1f61de6 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario	Framework	Baseline	Current	Change
Client bundle size (gzip)	vinext	142.3 KB	142.3 KB	⚫ -0.0%
Client entry size (gzip)	vinext	129.7 KB	129.7 KB	⚫ -0.0%
Dev server cold start	vinext	3.37 s	3.34 s	⚫ -1.0%
Production build time	vinext	3.91 s	3.93 s	⚫ +0.6%
RSC entry closure size (gzip)	vinext	127.9 KB	127.8 KB	⚫ -0.1%
Server bundle size (gzip)	vinext	226.0 KB	226.0 KB	⚫ +0.0%

View detailed results and traces

_{🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head}

ask-bonk · 2026-09-22T11:46:06Z

Posted 3 actionable inline findings.

github run

james-elicx · 2026-09-22T11:51:41Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:01:56Z

Posted 3 actionable inline findings.

github run

james-elicx · 2026-09-22T12:17:45Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:22:23Z

Posted 1 actionable inline finding. Targeted tests pass after rebuilding vinext.

github run

james-elicx · 2026-09-22T12:39:52Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:43:16Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T12:46:16Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:48:35Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T13:07:48Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T13:11:24Z

Posted 2 actionable inline findings. Targeted unit tests pass.

github run

ask-bonk · 2026-09-22T15:28:21Z

@james-elicx Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

james-elicx · 2026-09-22T15:39:58Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

james-elicx · 2026-09-22T16:15:52Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T16:20:06Z

-        if (process.env.NODE_ENV !== resolvedNodeEnv) {
+        const preserveTestNodeEnv =
+          process.env.NODE_ENV === "test" &&
+          (mode === "test" || viteCliBuildConfigNodeEnv === "test");


P1: This still preserves NODE_ENV=test solely because Vite's mode is test, even when there is no direct CLI invocation to justify config-time compatibility. The existing programmatic config contract now fails (tests/build-optimization.test.ts:946): calling this hook for { command: "build", mode: "test" } leaves process.env.NODE_ENV as test instead of switching the actual build to production. CI's Vitest (unit 1/3) is failing on exactly that assertion. Please gate preservation on the captured direct-CLI test environment rather than mode === "test"; mode selects config/env files but should not select build-time NODE_ENV.

ask-bonk · 2026-09-22T16:20:11Z

Posted 1 actionable inline finding. Targeted lifecycle tests pass; CI confirms the reported NODE_ENV regression.

github run

james-elicx · 2026-09-22T16:27:06Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T16:30:38Z

+      index++;
+      continue;
+    }
+    if (arg.startsWith("-")) continue;


P2: Treat -- as the end of option parsing instead of skipping it. CAC treats everything after this marker as positional input, so vite -- build starts the dev server with build as the project root (confirmed against the bundled Vite CLI), while this loop skips -- and classifies it as a production build. Because getViteCliInvocation() runs at module load, that valid dev invocation gets NODE_ENV=production and loads .env.production before its Vite config executes. Stop command detection at -- and preserve the remaining positional arguments for the default dev command.

ask-bonk · 2026-09-22T16:30:42Z

Posted 1 actionable inline finding. Targeted unit tests pass.

github run

james-elicx · 2026-09-22T16:41:39Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T16:46:59Z

+      index++;
+      continue;
+    }
+    if (arg.startsWith("-")) continue;


P2: CAC also expands clustered short options, but this scanner skips the cluster wholesale. For example, the bundled Vite CLI accepts vite -dm staging build (-d plus -m staging) and selects the production build command, while commandArguments() skips -dm, sees staging as the first positional, and classifies the invocation as a dev server rooted there. That suppresses the vinext lifecycle and also loads the wrong config-time mode/env. Please account for CAC's short-option clustering (or derive command/mode from the authoritative parsed invocation) rather than treating every option-looking token as one flag.

ask-bonk · 2026-09-22T16:47:06Z

Posted 1 actionable inline finding. Targeted CLI invocation tests pass.

github run

james-elicx · 2026-09-22T16:52:55Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T16:56:33Z

No new actionable findings beyond the existing inline review comments.

github run

james-elicx · 2026-09-22T17:18:56Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:19:26Z

Not Found - https://docs.github.com/rest/reactions/reactions#create-reaction-for-an-issue-comment

github run

james-elicx · 2026-09-22T17:20:31Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:23:25Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T17:29:29Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T17:32:07Z

No new actionable findings beyond the existing inline review comments.

github run

james-elicx added this pull request to stack #3382 September 22, 2026 11:37

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/utils/vite-cli-invocation.ts Outdated

Comment thread packages/vinext/src/index.ts Outdated

Comment thread packages/vinext/src/config/prerender.ts

james-elicx force-pushed the codex/vite-build-lifecycle branch from 078c7d0 to ab7311c Compare September 22, 2026 11:51

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

james-elicx force-pushed the codex/vite-build-lifecycle branch from ab7311c to 86e2104 Compare September 22, 2026 12:16

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/utils/vite-cli-invocation.ts Outdated

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/index.ts Outdated

james-elicx force-pushed the codex/vite-build-lifecycle branch from 7f41ce5 to 9341cf4 Compare September 22, 2026 12:44

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

james-elicx force-pushed the codex/vite-build-lifecycle branch from 9341cf4 to ae580bb Compare September 22, 2026 13:06

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/index.ts Outdated

Comment thread packages/vinext/src/build/lifecycle.ts

feat(build): run lifecycle through Vite

9aac569

fix(build): preserve explicit test-mode config env

d1b6b9a

james-elicx added 4 commits September 22, 2026 16:43

fix(build): decouple test env from Vite mode

1c9ff5f

test(build): type lifecycle environment cases

11f3063

fix(build): limit test env to config loading

199c8fe

fix(build): preserve builder hook ownership

cb032e4

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

fix(build): preserve test env only for CLI config

74eaa6a

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

fix(build): respect the Vite option delimiter

3ca994d

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

fix(build): parse clustered Vite short options

637834a

fix(build): detect positional App Router roots

be931ea

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/index.ts Outdated

fix(build): resolve configured App roots from Vite root

a6bef91

Conversation

james-elicx commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

pkg-pr-new Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

github-actions Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance benchmarks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 22, 2026 •

edited

Loading

github-actions Bot commented Sep 22, 2026 •

edited

Loading

ask-bonk Bot commented Sep 22, 2026 •

edited

Loading