refactor(build): share the production lifecycle by james-elicx · Pull Request #3376 · cloudflare/vinext

james-elicx · 2026-09-22T11:36:58Z

Summary

extract production preparation and finalization into one typed lifecycle
preserve build identities, secrets, hybrid Pages builds, prerendering, standalone output, precompression, and reports
keep lifecycle reports visible even when Vite logging is silent
keep the existing CLI as the caller in this layer

Validation

lifecycle and command contract tests
vp check
vp run vinext#build

PR 2 of 7.

pkg-pr-new · 2026-09-22T11:38:07Z

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3376

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3376

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3376

vinext

npm i https://pkg.pr.new/vinext@3376

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3376

commit: 1f61de6

james-elicx · 2026-09-22T11:38:36Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T11:41:10Z

Posted 1 actionable inline finding. Targeted test and checks passed.

github run

github-actions · 2026-09-22T11:41:25Z

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original
response-store-demo	preview	production
workers-cache	preview	production
kv	preview	production
static-export	preview	production
web	preview	production

github-actions · 2026-09-22T11:41:48Z

Performance benchmarks

Compared 1f61de6 against base 45976d7 using alternating same-runner rounds. Next.js was unchanged and skipped.

1 improved · 0 regressed · 5 within ±1.5%

Scenario	Framework	Baseline	Current	Change
Client bundle size (gzip)	vinext	142.3 KB	142.3 KB	⚫ -0.0%
Client entry size (gzip)	vinext	129.7 KB	129.7 KB	⚫ 0.0%
Dev server cold start	vinext	3.44 s	3.38 s	🟢 -1.6%
Production build time	vinext	3.80 s	3.80 s	⚫ +0.1%
RSC entry closure size (gzip)	vinext	127.9 KB	127.9 KB	⚫ +0.0%
Server bundle size (gzip)	vinext	226.0 KB	226.0 KB	⚫ +0.0%

View detailed results and traces

_{🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head}

james-elicx · 2026-09-22T12:17:44Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:24:00Z

LGTM!

github run

james-elicx · 2026-09-22T12:39:52Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

james-elicx · 2026-09-22T12:46:16Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T12:47:11Z

Posted 1 actionable inline finding.

github run

james-elicx · 2026-09-22T13:07:48Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T13:14:01Z

Posted 1 actionable inline finding. Targeted tests and checks passed.

github run

james-elicx · 2026-09-22T13:39:28Z

/bigbonk review for issues\n\nTime limit: 8 minutes. Complete the review and post all findings within that limit.

james-elicx · 2026-09-22T13:44:27Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T13:46:48Z

LGTM!

github run

james-elicx · 2026-09-22T14:43:08Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T14:49:00Z

LGTM!

github run

james-elicx · 2026-09-22T15:25:53Z

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

ask-bonk · 2026-09-22T15:26:34Z

+      rscBuildIdentity: process.env.__VINEXT_SHARED_RSC_BUILD_IDENTITY,
+      rscCompatibilityId: process.env.__VINEXT_SHARED_RSC_COMPATIBILITY_ID,
+    };
+    prepareBuildOutput(lifecycleContext);


[P2] Keep the standalone preflight ahead of dependency upgrades

This call now performs the standalone vinext dist/ existence check, but it runs after the getReactUpgradeDeps() block above. Previously that preflight ran before the automatic package-manager invocation, so a broken/source installation failed without modifying the application; now an App Router project that needs a React upgrade can install dependencies and only then hit the predictable missing-dist error. Please split the standalone validation from output cleanup (or otherwise run just that check before the React upgrade) while retaining cleanup at its current phase.

ask-bonk · 2026-09-22T15:26:40Z

Posted 1 actionable inline finding.

github run

ask-bonk · 2026-09-22T15:26:41Z

Not Found - https://docs.github.com/rest/reactions/reactions#list-reactions-for-an-issue-comment

github run

ask-bonk · 2026-09-22T15:26:43Z

@james-elicx Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

james-elicx added this pull request to stack #3382 September 22, 2026 11:37

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

james-elicx force-pushed the codex/shared-build-lifecycle branch from 142155d to 5419c80 Compare September 22, 2026 12:16

james-elicx force-pushed the codex/shared-build-lifecycle branch from 5419c80 to e65cd2d Compare September 22, 2026 12:44

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

james-elicx force-pushed the codex/shared-build-lifecycle branch from e65cd2d to 07becc3 Compare September 22, 2026 13:06

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/vinext/src/build/lifecycle.ts Outdated

james-elicx added 6 commits September 22, 2026 14:21

refactor(build): share the production lifecycle

8164917

refactor(build): keep lifecycle phases private

66bff7e

style(build): format private lifecycle phases

6e20e27

fix(build): preserve lifecycle reports in silent mode

df9996d

fix(build): preserve raw cleanup opt-out

b001afc

fix(build): clean output before config resolution

1f61de6

james-elicx force-pushed the codex/shared-build-lifecycle branch from 07becc3 to 1f61de6 Compare September 22, 2026 13:37

ask-bonk Bot reviewed Sep 22, 2026

View reviewed changes

Conversation

james-elicx commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

pkg-pr-new Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

github-actions Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance benchmarks

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

james-elicx commented Sep 22, 2026

Uh oh!

ask-bonk Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

ask-bonk Bot commented Sep 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

james-elicx commented Sep 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 22, 2026 •

edited

Loading

github-actions Bot commented Sep 22, 2026 •

edited

Loading