Convert remaining .mjs scripts to TypeScript - #549
Merged
Merged
Conversation
#233 moved `scripts/` to type-stripped TypeScript but left four `.mjs` files behind: the two gatekeeper `build-app` scripts, workshop-backend's browser-runtime builder, and the oxlint plugin. They now run as `.ts` and are type-checked by `pnpm types:scripts`. - `build-browser-runtime` moves into `workshop-backend/scripts/`, beside the other Node-only tool that `scripts/tsconfig.json` already covers. - The oxlint plugin is typed against `@oxlint/plugins`, added as a type-only dev dependency pinned to the version Vite+ pins; its test fails if the two drift. oxlint loads a `.ts` plugin as-is. - Stale references to already-converted `.mjs` files are corrected. Co-Authored-By: Claude Code <noreply@anthropic.com>
github-actions
Bot
added
kernel
Preview:
|
|
LGTM! |
Maximo-Guk
marked this pull request as ready for review
September 22, 2026 15:19
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
AshishKumar4
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the four
.mjsfiles #233 left behind (two gatekeeperbuild-appscripts, workshop-backend's browser-runtime builder, the oxlint plugin) to type-checked TypeScript.The plugin is typed via a type-only
@oxlint/pluginsdev dependency pinned to Vite+'s version, with a test guarding the pin.