Skip to content

chore(gatekeeper-kit): document and test staged gatekeeper reconnects - #520

Merged
ndisidore merged 1 commit into
mainfrom
chore/gk-kit-cred-stage-followups
Sep 18, 2026
Merged

chore(gatekeeper-kit): document and test staged gatekeeper reconnects#520
ndisidore merged 1 commit into
mainfrom
chore/gk-kit-cred-stage-followups

Conversation

@ndisidore

@ndisidore ndisidore commented Sep 17, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Member

Small docs and conformance tests as a followup for #464

Devin Review

@github-actions github-actions Bot added the gatekeeper Changes to a gatekeeper integration label Sep 17, 2026
@ndisidore ndisidore changed the title Document and test staged gatekeeper reconnects chore(gatekeeper-kit): document and test staged gatekeeper reconnects Sep 17, 2026
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Sep 17, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

Preview: pr520-chore-gk-kit-1a9fc172

https://pr520-chore-gk-kit-1a9fc172-router.cloudflare-os-previews.workers.dev

Dashboard · deleted when this PR closes

@ask-bonk

This comment was marked as outdated.

Sign in to view
@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from b757a9e to 8eb5668 Compare September 17, 2026 16:43
@ask-bonk

This comment was marked as outdated.

Sign in to view
@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 8eb5668 to 8aa19c7 Compare September 17, 2026 17:03
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

This comment was marked as outdated.

Sign in to view
@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 8aa19c7 to d9f235e Compare September 17, 2026 17:27
@ask-bonk

This comment was marked as outdated.

Sign in to view
@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch 2 times, most recently from b0cfda6 to f63bd77 Compare September 17, 2026 18:32
@ask-bonk

This comment was marked as outdated.

Sign in to view
ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 17, 2026

Copy link
Copy Markdown

Posted 1 actionable inline review comment.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from f63bd77 to 9927f27 Compare September 17, 2026 19:01
ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 17, 2026

Copy link
Copy Markdown

Posted 1 actionable inline review comment.

  • P2 plans/gatekeeper-kit.md:2824-2825: The fixture plan still tests reconnect via credentialsRestored(). Browser reconnects must test reconnectComplete() plus exact-stage commitReconnect() instead.

Gatekeeper-kit tests pass.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 9927f27 to 77f5db5 Compare September 17, 2026 19:33
ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 17, 2026

Copy link
Copy Markdown

Posted 1 actionable inline review comment.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 77f5db5 to 1125194 Compare September 17, 2026 19:59
ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 17, 2026

Copy link
Copy Markdown

Posted 1 actionable inline review comment.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 1125194 to 2436df6 Compare September 17, 2026 20:24
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 2436df6 to b2d004d Compare September 17, 2026 21:54
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 17, 2026

Copy link
Copy Markdown

Posted 3 actionable inline review comments.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from b2d004d to aeb770d Compare September 17, 2026 23:21
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 17, 2026

Copy link
Copy Markdown
  • P2 packages/gatekeeper-github/src/github.ts:1383: deleteAlarm() can reject after credentials are committed and the single-use ticket is spent, leaving Workshop permanently reporting failed restoration. Alarm cleanup must be best-effort after activation.
  • P2 packages/gatekeeper-github/src/github.ts:1759: Calling loader() without the cached ETag disables conditional GitHub requests. Expired entries now consume API quota on every reload, risking rate-limit failures for paginated reads.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from aeb770d to 1ab081f Compare September 17, 2026 23:40
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 17, 2026

Copy link
Copy Markdown

Posted 2 actionable inline review comments.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 1ab081f to 30d50f5 Compare September 18, 2026 00:11
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 18, 2026

Copy link
Copy Markdown

Posted 1 actionable inline review comment.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 30d50f5 to 0236b85 Compare September 18, 2026 01:06
@ask-bonk

ask-bonk Bot commented Sep 18, 2026

Copy link
Copy Markdown
  • P2 plans/gatekeeper-kit.md:2352-2353: It consumes the stage when reconnectComplete() rejects, contradicting USAGE.md:126-128. RPC rejection is ambiguous; preserve the stage for exact commit or expiry.

Gatekeeper-kit tests and build pass.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 0236b85 to d1359be Compare September 18, 2026 01:23
ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 18, 2026

Copy link
Copy Markdown

Posted 1 actionable inline review comment.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from d1359be to 8f91a3f Compare September 18, 2026 11:20
ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

ask-bonk Bot commented Sep 18, 2026

Copy link
Copy Markdown

Posted 1 actionable inline review comment.

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 8f91a3f to 55357c6 Compare September 18, 2026 11:41
@ask-bonk

ask-bonk Bot commented Sep 18, 2026

Copy link
Copy Markdown

LGTM!

github run

@ndisidore
ndisidore force-pushed the chore/gk-kit-cred-stage-followups branch from 55357c6 to e69f9b2 Compare September 18, 2026 12:00
@ask-bonk

ask-bonk Bot commented Sep 18, 2026

Copy link
Copy Markdown

LGTM!

github run

@ndisidore
ndisidore merged commit ca87261 into main Sep 18, 2026
14 checks passed
@ndisidore
ndisidore deleted the chore/gk-kit-cred-stage-followups branch September 18, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@ask-bonk ask-bonk[bot] ask-bonk[bot] left review comments
@Maximo-Guk Maximo-Guk Maximo-Guk approved these changes

Assignees

No one assigned

Labels

gatekeeper Changes to a gatekeeper integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndisidore @Maximo-Guk