Pipeline Workshop Feedback #84
Description
Org Webhook did not work on creation. Have to manually kick the jobs off after changes made in GitHub. Does this have anything to do with the fact I ran as Admin? I wouldn't think so. I don't know password for attendees.
- Links from Lab1 -> Lab2 at the bottom of the instruction page do not work. However Lab navigation on the left works fine.
- No text links to Lab3 from Lab2. I don't think this is a big deal. Arrows and guide work.
- Because Webhook wasn't working the PR build check did not appear in the PR from dev to master in lab3 rescan of org did pick up master branch.
- No text links to Lab4 from Lab3. I don't think this is a big deal. Arrows and guide work.
- Lab4 adding agent block to test stage. Test stage does not exist on this branch because we added those changes to the main branch in lab3. This makes step 5 in lab 4 a little confusing. However you can copy/paste the block from step 5 and be up to date. (did I miss something?) - Image on step 6 of Lab4 is misleading we just made this commit to the dev branch but the image shows both stages Test & Build Push Image as green. Build push should only happen on Main branch and we haven't submitted a PR yet.
- Lab4 end. It never mentions a commit directly to main or a PR but Lab5 starts on the main branch so I assume the nodejs.yaml is supposed to be merged into main. (Proceeded after merge to main). The main branch now is 2 commits ahead of dev and two behind from updates I had to make to Jenkinsfile and nodejs-pod.yaml. I think its just the instructions need clarity around the branches.
- No issues with Cross team Lab.
Overall really good and some cool new things added. I think the branch confusion and the webhook issue are the only real concerns.
Originally posted by @johns2te in #80 (comment)
Metadata
Metadata
Assignees
Labels
No labels