Validate endpoints before creating them

Use the `/endpoints/actions` validation API, which takes the `platform`
and `connection info` instead of an `endpoint ID`, and validate before
creating the endpoint, so invalid endpoints are no longer saved.

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>

Author: mihaelabalutoiu

coriolisclient/cli/endpoints.py

@@ -151,20 +151,20 @@ def take_action(self, args):
                 "--connection-secret, but not both")
 
         conn_info = get_connection_info_from_args(args)
-        endpoint = self.app.client_manager.coriolis.endpoints.create(
+        endpoints = self.app.client_manager.coriolis.endpoints
+        if not args.skip_validation:
+            valid, message = endpoints.validate_connection(
+                args.provider, conn_info, regions=args.regions)
+            if not valid:
+                raise exceptions.EndpointConnectionValidationFailed(message)
+
+        endpoint = endpoints.create(
             args.name,
             args.provider,
             conn_info,
             args.description,
             regions=args.regions)
 
-        if not args.skip_validation:
-            valid, message = (
-                self.app.client_manager.coriolis.endpoints.validate_connection(
-                    endpoint.id))
-            if not valid:
-                raise exceptions.EndpointConnectionValidationFailed(message)
-
         return EndpointDetailFormatter().get_formatted_entity(endpoint)
 
 
@@ -292,6 +292,9 @@ def get_parser(self, prog_name):
     def take_action(self, args):
         endpoints = self.app.client_manager.coriolis.endpoints
         endpoint_id = endpoints.get_endpoint_id_for_name(args.id)
-        valid, message = endpoints.validate_connection(endpoint_id)
+        endpoint = endpoints.get(endpoint_id)
+        valid, message = endpoints.validate_connection(
+            endpoint.type, endpoint.connection_info.to_dict(),
+            regions=endpoint.mapped_regions)
         if not valid:
             raise exceptions.EndpointConnectionValidationFailed(message)

coriolisclient/v1/endpoints.py

@@ -76,10 +76,13 @@ def get_inventory_csv(self, endpoint, source_environment=None):
         resp = self.client.get(url, headers={'Accept': 'text/csv'})
         return resp.text
 
-    def validate_connection(self, endpoint):
+    def validate_connection(self, platform, connection_info, regions=None):
         data = self.client.post(
-            '/endpoints/%s/actions' % base.getid(endpoint),
-            json={'validate-connection': None}).json()
+            '/endpoints/actions',
+            json={'validate-connection': {
+                "platform": platform,
+                "connection_info": connection_info,
+                "mapped_regions": regions or []}}).json()
         validate_data = data["validate-connection"]
         return validate_data.get("valid"), validate_data.get("message")
 

samples/endpoint_samples.py

@@ -112,7 +112,10 @@ def validate_endpoint(coriolis, endpoint, raise_on_error=True):
     :param endpoint: endpoint object or ID
     :return: (bool, str) tuple containing the result and possible errors
     """
-    is_valid, error_msg = coriolis.endpoints.validate_connection(endpoint)
+    endpoint = coriolis.endpoints.get(endpoint)
+    is_valid, error_msg = coriolis.endpoints.validate_connection(
+        endpoint.type, endpoint.connection_info.to_dict(),
+        regions=endpoint.mapped_regions)
 
     if raise_on_error and not is_valid:
         raise Exception("Endpoint validation failed: %s" % error_msg)