Enhancement/string variables (#11)

* extend string variables declarations

* Bump version to 0.0.10

Author: sky3d

library.json

@@ -23,7 +23,7 @@
     "build": {
       "flags": "-DMQTT_MAX_PACKET_SIZE=1024 -DMQTT_MAX_TRANSFER_SIZE=128"
     },
-    "version": "0.0.9",
+    "version": "0.0.10",
     "examples": "examples/*/*.ino",
     "frameworks": "arduino",
     "platforms": [

library.properties

@@ -1,5 +1,5 @@
 name=cloud4rpi-esp-arduino
-version=0.0.9
+version=0.0.10
 author=Cloud4RPi <[email protected]>
 maintainer=Cloud4RPi <[email protected]>
 sentence=Connect a board to the Cloud4RPi control panel using MQTT - https://cloud4rpi.io.

src/Cloud4RPi.cpp

@@ -25,7 +25,6 @@ Cloud4RPi::Cloud4RPi(const String &_deviceToken, const String &_server, int _por
 
 Cloud4RPi::~Cloud4RPi() {
     if (mqttClient != NULL) {
-        delete mqttClient;
         mqttClient = NULL;
     }
 
@@ -98,9 +97,9 @@ void Cloud4RPi::declareBoolVariable(const String& varName, C4R_BOOL_HANDLER_SIGN
 }
 
 void Cloud4RPi::declareNumericVariable(const String& varName, C4R_NUMERIC_HANDLER_SIGNATURE) {
-      if (!isVariableExists(varName)) {
+    if (!isVariableExists(varName)) {
         variables->declare<double>(varName, VAR_TYPE_NUMERIC, cmdHandler);
-      }
+    }
 }
 
 void Cloud4RPi::declareStringVariable(const String& varName) {
@@ -132,11 +131,11 @@ double Cloud4RPi::getNumericValue(const String& varName) {
     return variables->getValue<double>(varName);
 }
 String Cloud4RPi::getStringValue(const String& varName) {
-    return String(variables->getValue<char*>(varName));
+    return variables->getValue<String>(varName);
 }
 
 String Cloud4RPi::getDiagValue(const String& varName) {
-    return String(diagnostics->getValue<char*>(varName));
+    return diagnostics->getValue<String>(varName);
 }
 
 void Cloud4RPi::setVariable(const String& varName, bool value) {
@@ -167,11 +166,19 @@ void Cloud4RPi::setVariable(const String& varName, double value) {
     variables->setValue(varName, value);
 }
 
-void Cloud4RPi::setVariable(const String& varName, String value) {
+void Cloud4RPi::setVariable(const String& varName, const char* value) {
+    variables->setValue(varName, String(value));
+}
+
+void Cloud4RPi::setVariable(const String& varName, const String& value) {
     variables->setValue(varName, value);
 }
 
-void Cloud4RPi::setDiagVariable(const String& varName, String value) {
+
+void Cloud4RPi::setDiagVariable(const String& varName, const char* value) {
+    diagnostics->setValue(varName, String(value));
+}
+void Cloud4RPi::setDiagVariable(const String& varName, const String& value) {
     diagnostics->setValue(varName, value);
 }
 

src/Cloud4RPi.h

@@ -31,7 +31,7 @@ namespace {
     const String& VAR_TYPE_NUMERIC = "numeric";
     const String& VAR_TYPE_STRING = "string";
 
-    const int JSON_BUFFER_SIZE = 500;
+    const int JSON_BUFFER_SIZE = 1024;
 }
 
 const int C4R_RECONNECT_TIMEOUT = 1000; // milliseconds
@@ -74,9 +74,12 @@ friend class C4RMqttCallback;
     void setVariable(const String& varName, unsigned long value);
     void setVariable(const String& varName, float value);
     void setVariable(const String& varName, double value);
-    void setVariable(const String& varName, String value);
-    void setDiagVariable(const String& varName, String value);
-
+    void setVariable(const String& varName, const char* value);
+    void setVariable(const String& varName, const String& value);    
+    
+    void setDiagVariable(const String& varName, const char* value);
+    void setDiagVariable(const String& varName, const String& value);
+    
     bool publishConfig();
     bool publishData();
     bool publishDiag();