Skip to content

Commit 0564ab4

Browse files
committed
typo, update test - add :rename case
1 parent a96edfe commit 0564ab4

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/main/clojure/cljs/analyzer.cljc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3129,7 +3129,7 @@
31293129
(when-not (some #{original} referred)
31303130
(throw (error env
31313131
(str "Renamed symbol " original " not referred"))))
3132-
(assoc m renamed (symbol "js " (str (str lib) "." (str original)))))
3132+
(assoc m renamed (symbol "js" (str (str lib) "." (str original)))))
31333133
{} renamed)}))))))
31343134

31353135
(defn parse-require-spec [env macros? deps aliases spec]

src/test/clojure/cljs/analyzer_tests.clj

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -398,9 +398,15 @@
398398
(let [parsed (ana/parse-global-require-spec {} (atom {:fns {}})
399399
'[React :refer [createElement] :as react])]
400400
(is (= parsed
401-
'{:require {react js/React
402-
React js/React}
403-
:use {createElement js/React}}))))
401+
'{:require {react js/React
402+
React js/React}
403+
:use {createElement js/React}})))
404+
(let [parsed (ana/parse-global-require-spec {} (atom {:fns {}})
405+
'[React :refer [createElement] :rename {createElement create} :as react])]
406+
(is (= parsed
407+
'{:require {react js/React
408+
React js/React}
409+
:rename {create js/React.createElement}}))))
404410

405411
(deftest test-cljs-1785-js-shadowed-by-local
406412
(let [ws (atom [])]

0 commit comments

Comments
 (0)