Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent names for :group-id/:artifact-id #525

Open
tobias opened this issue May 5, 2016 · 4 comments
Open

Use consistent names for :group-id/:artifact-id #525

tobias opened this issue May 5, 2016 · 4 comments

Comments

@tobias
Copy link
Member

tobias commented May 5, 2016

Depending on where you are in the codebase, we use :group/:name, :group-id/:artifact-id, :group_name/:jar_name, and possibly others. This means we end up doing a lot of key renaming when crossing boundaries (db/index/poms), which is error-prone and mentally inefficient.

@tobias tobias added the cleanup label May 5, 2016
@danielcompton
Copy link
Member

Good plan. We had the same problem at work recently and created a glossary document defining standard names and their definitions.

@mynomoto
Copy link
Contributor

mynomoto commented Jan 9, 2017

Is :group-id/:artifact-id the canonical one?

@danielcompton
Copy link
Member

I think that should probably be?

@tobias
Copy link
Member Author

tobias commented Jan 10, 2017

Yes, those are the preferred names. Be aware that this is a large change, and may be painful to implement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants