remove durable_deletes

Author: Shubham8287

crates/core/src/db/relational_db.rs

@@ -842,7 +842,7 @@ impl RelationalDB {
             let truncates: IntSet<TableId> = tx_data.truncates().collect();
 
             let deletes: Box<_> = tx_data
-                .durable_deletes()
+                .deletes()
                 .filter(|(table_id, _)| is_not_ephemeral_table(table_id))
                 .map(|(table_id, rowdata)| Ops {
                     table_id: *table_id,
@@ -2420,6 +2420,27 @@ mod tests {
         TableSchema::from_module_def(&def, table, (), TableId::SENTINEL)
     }
 
+    fn view_module_def() -> ModuleDef {
+        let mut builder = RawModuleDefV9Builder::new();
+
+        let return_type_ref = builder.add_algebraic_type(
+            [],
+            "my_view_return_type",
+            AlgebraicType::product([("b", AlgebraicType::U8)]),
+            true,
+        );
+        builder.add_view(
+            "my_view",
+            0,
+            true,
+            false,
+            ProductType::unit(),
+            AlgebraicType::array(AlgebraicType::Ref(return_type_ref)),
+        );
+        let raw = builder.finish();
+        raw.try_into().expect("table validation failed")
+    }
+
     fn table_auto_inc() -> TableSchema {
         table(
             "MyTable",
@@ -2525,7 +2546,7 @@ mod tests {
         v: u8,
     ) -> ResultTest<()> {
         let to_bsatn = |pv: &ProductValue| {
-            Bytes::from(to_vec(&AlgebraicValue::Array([pv.clone()].into())).expect("bstan serialization failed"))
+            Bytes::from(bsatn::to_vec(&AlgebraicValue::Array([pv.clone()].into())).expect("bstan serialization failed"))
         };
 
         let row_pv = |v: u8| product![v];
@@ -2552,7 +2573,6 @@ mod tests {
             .collect()
     }
 
-
     #[test]
     fn test_view_tables_are_ephemeral() -> ResultTest<()> {
         let stdb = TestDB::durable()?;

crates/datastore/src/traits.rs

@@ -281,17 +281,6 @@ impl TxData {
         self.deletes.iter()
     }
 
-    /// Obtain an iterator over the deleted rows per table,
-    /// excluding ephemeral tables.
-    pub fn durable_deletes(&self) -> impl Iterator<Item = (&TableId, &Arc<[ProductValue]>)> + '_ {
-        self.deletes.iter().filter(move |(table_id, _)| {
-            !self
-                .ephemeral_tables
-                .as_ref()
-                .is_some_and(|etables| etables.contains(*table_id))
-        })
-    }
-
     /// Get the `i`th deleted row for `table_id` if it exists
     pub fn get_ith_delete(&self, table_id: TableId, i: usize) -> Option<&ProductValue> {
         self.deletes.get(&table_id).and_then(|rows| rows.get(i))