Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add caveat about import-vars? #68

Open
lread opened this issue Oct 20, 2022 · 2 comments
Open

docs: add caveat about import-vars? #68

lread opened this issue Oct 20, 2022 · 2 comments

Comments

@lread
Copy link
Contributor

lread commented Oct 20, 2022

Some time ago I merged rewrite-cljs v0 and rewrite-clj v0 to create rewrite-clj v1.

Rewrite-clj v0 used an inlined version of potemkin import-vars.
My initial decision was to create an inlined cljs version of import-vars to match.
This was a ton of learning and effort, but it technically worked.

Over time I discovered import-vars does has enough downsides that I ultimately decided to switch to code generation instead. Here are my rewrite-clj v1 notes on import-vars.

So that users can make a more informed choice, I think we should probably mention some of the cons of using import-vars in the readme. I am happy to take a stab at this.

@KingMob
Copy link
Contributor

KingMob commented May 1, 2023

Sure, want to submit a PR?

@lread
Copy link
Contributor Author

lread commented May 1, 2023

Thanks, I'll take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants