Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow chains of replies #28

Open
ckolderup opened this issue Feb 27, 2023 · 1 comment
Open

follow chains of replies #28

ckolderup opened this issue Feb 27, 2023 · 1 comment
Labels
ActivityPub work involving the ActivityPub protocol

Comments

@ckolderup
Copy link
Owner

as of Feb 2023 if someone replies to a Fedimarks post on Mastodon it gets queued as a comment in Fedimarks, but if someone replies to that Mastodon reply, it doesn't.

To fix this, we'll need to index all existing replies and look those up as reply-to ids to check when determining what bookmark to file a comment under. We could retain this specific reply-to information and build threaded comments on the fedimarks side, or experiment with flattening it all, but we should at least keep enough information to try some things out on the frontend.

@ckolderup ckolderup added the ActivityPub work involving the ActivityPub protocol label Sep 3, 2023
@TomCasavant
Copy link
Contributor

I was messing around with this since I am routinely receiving comments that wouldn't show up on the bookmark because they're replies to me or to others and not directly on the bookmark this is what I ended up with:
image
Essentially I just added another column in the comments table for in_reply_to_url, so if a comment comes in with an inReplyToId that matches one of my existing stored comments then I add that to the table referencing the original bookmark ID and the replied to comment URL. I'm open to creating a PR for this but I'm planning on waiting until #138 gets merged in as I'm not sure what kind of database changes that introduces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ActivityPub work involving the ActivityPub protocol
Projects
None yet
Development

No branches or pull requests

2 participants