feat: switch to alembic migrations #540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amercader , I mentioned this change at the dev meeting
To make this extension compatible with CKAN after merging sqlalchemy-2.0 PR, at least we have to pass
engine
to allcreate
andexists
callsBut, if ckanext-harvest targets only CKAN >= v2.9, we can switch to alembic migrations. When I had done it, I decided to move all table definitions to the top level of the module.
Finally, I created a second migration. It adds PostgreSQL level
ON DELETE CASCADE
to all the foreign keys. It's not required for sqlalchemy upgrade, but it really simplifies cleaning the tables manually