-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact images broken by contact-summary.js when using Drupal 'seven' theme. #374
Comments
I'm seeing this issue with 5.10.x (and earlier versions) using Adminimal as the CiviCRM theme. The contact-summary.js file is getting loaded even though I'm only using Shoreditch for Mosaico. |
I confirm the problem. We are using adminimal as the CiviCRM theme and Shoreditch for Mosaico only. Caused by #215 |
"If the js is blocked the image shows in the correct position." How might I achieve this? |
In Chrome, inspect => network tab. |
Fix for civicrm#374 if you are only using shoreditch for mosaico.
I just pushed a patch so that the contact summary javascript is only pulled in if the site is configured to use shoreditch throughout civicrm. |
Fix for civicrm#374 if you are only using shoreditch for mosaico.
Can replicate the same error on Drupal 9.2.6 The reason seems to be the body class missing from D8 CiviCRM, eg, I see Since the class is missing from D9 sites, none of these css style work. A quick workaround is to add
on contact summary pages. |
CiviCRM 5.11.0
Shoreditch 0.1-alpha28 (required for Mosaico)
Using 'Seven' as the CiviCRM admin theme.
Contact images are briefly displayed on eg civicrm/contact/view?reset=1&cid=22437
contact-summary.js is still loaded from
sites/default/files/civicrm/extensions/org.civicrm.shoreditch-0.1-alpha28/js/contact-summary.js?r=zQ7oF
It appears to move the contact image from
< div id="crm-contact-thumbnail" >
to further up the page where it is now invisible (probably because of CSS).
If the js is blocked the image shows in the correct postion.
The text was updated successfully, but these errors were encountered: