Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHOR-77: Increase specificity for .status-overdue color #297

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

AkA84
Copy link
Contributor

@AkA84 AkA84 commented Sep 13, 2018

Closes #242 , which also contains a nice in-depth analysis with screenshots in this comment

Unfortunately I don't see any other way to fix this but to have a selector with stronger specificity. Not only we have our own style causing the issue, but also the seven theme is contributing to it.

After the fix:
after

@AkA84 AkA84 added the bug label Sep 13, 2018
@AkA84 AkA84 merged commit ff2062f into master Sep 13, 2018
@AkA84 AkA84 deleted the SHOR-77-fix-activities-overdue-color branch September 13, 2018 11:28
@jensschuppe
Copy link

This seems to cover overdue activities only. However, as pointed out in #242, the fix needs to address more selectors (from CiviCRM core CSS):

.crm-container del,
.crm-container .crm-is_deleted,
.crm-container table.caseSelector td.status-urgent,
.crm-container .font-red,
.crm-container .status-removed,
.crm-container .status-overdue,
.crm-container .status-fatal,
.crm-container .status-hold,
.crm-container .status-past,
.crm-contact-deceased,
.crm-container .status-warning {
    color: #E43D2B !important;
}

Also, the fix makes the color rule apply to table cells within a .contact-activity-selector-activity element only, which might be ok, if that's the only place where these classes are used, but the original core styles indicate that these classes may be used anywhere within a .crm-container element.

@AkA84
Copy link
Contributor Author

AkA84 commented Sep 13, 2018

@jensschuppe you are right, I should have said explicitly that this PR fixes only the specific issue that you reported in #242

Researching and troubleshoot all the potential locations that might be affected by seven and/or shoreditch will take much longer, and I wanted to have a quick solution in place in the meantime so that the usability of the Activities tab is not negatively affected by the theme

Sorry for the miscommunication!

@jensschuppe
Copy link

No need to apologize, and thanks for working on it.

Maybe I didn't point out clearly enough that it's more than just overdue activities (as can be seen in the CSS I posted), and I chose those as an example to illustrate the issue.

For the issue of fixing the other selectors not getting lost, would you open #242 again for more commits or should we open another issue?

@AkA84
Copy link
Contributor Author

AkA84 commented Sep 13, 2018

sure @jensschuppe , just did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"warning labels and messages" style rules overridden
3 participants