Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong pypi_name in the json file #3

Open
Neradoc opened this issue Aug 18, 2021 · 0 comments
Open

Wrong pypi_name in the json file #3

Neradoc opened this issue Aug 18, 2021 · 0 comments

Comments

@Neradoc
Copy link

Neradoc commented Aug 18, 2021

The pypi name of displayio_annotation in the json file is incorrect

  • setup.py says circuitpython-displayio-annotation
  • the json file says "pypi_name": "circuitpython-org-displayio-annotation"

I believe circuitpython-build-tools uses the repository name:

https://github.com/adafruit/circuitpython-build-tools/blob/bdcdafdb903fc4faaaec619603d2b59bab10ccea/circuitpython_build_tools/scripts/build_bundles.py#L107-L110
https://github.com/adafruit/circuitpython-build-tools/blob/bdcdafdb903fc4faaaec619603d2b59bab10ccea/circuitpython_build_tools/scripts/build_bundles.py#L60-L67

Outside of renaming the module on pypi, or the repository, which are probably valid options that are not gonna break much things yet, this could be handled by having the pypi name in an additional metadata file, same as this: adafruit/circup#96 (comment) once circup moves to using the json file. (Which would require an update to circuitpython-build-tools).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant