Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add captions to m.file, m.image, m.video, and m.audio #2059

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

nexy7574
Copy link

@nexy7574 nexy7574 commented Nov 17, 2024

Description

This PR will introduce rendering file captions.
These were introduced in spec v1.10, and have recently seen wide adoption amongst Element and other clients. It is time that cinny had this too.

Sending captions is out of scope for this PR and will be introduced later.

Fixes #1646

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Copy link

github-actions bot commented Nov 17, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@nexy7574
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Nov 17, 2024
Copy link

github-actions bot commented Nov 17, 2024

Preview: https://2059--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@nexy7574 nexy7574 changed the title Add captions to m.image Add captions to m.file, m.image, m.video, and m.audio Nov 18, 2024
src/app/components/RenderMessageContent.tsx Outdated Show resolved Hide resolved
src/app/components/RenderMessageContent.tsx Outdated Show resolved Hide resolved
src/app/features/room/RoomInput.tsx Outdated Show resolved Hide resolved
src/app/features/room/RoomInput.tsx Outdated Show resolved Hide resolved
src/app/features/room/RoomInput.tsx Outdated Show resolved Hide resolved
@nexy7574 nexy7574 requested a review from ajbura December 16, 2024 14:58
Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes!

src/app/components/RenderMessageContent.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: MSC2530 support for Media Captions
3 participants