rooms that have been replaced still show up in room list

[williamkray]

Describe the bug

now that cinny has a better user flow for rooms that have been upgraded, it is also rendering the old room separately from the new room. this means that unless you leave the old room (thus making its contents inaccessible) you will have redundant room lists.

Reproduction

1. join/create a room
2. upgrade the room using another client
3. join the upgraded room
4. there are now two rooms with the same name in your room list, one which has been tombstoned and the replacement.
   

this can be especially confusing if the room is part of a space, as the old room will be removed from the space. so both rooms will exist, the old room listed in the "Home" navigation category and the new room found under the space appropriately.

Expected behavior

the old room should not be in the room list, but should be accessible only through the new room's settings to browse for historical purposes. it should for all other intents be considered "replaced" in the user interface by the new room.

Platform and versions

linux, firefox, cinny 3.0.0

Additional context

No response

[ajbura]

This is intentional as previously there was not any easy way to leave them.

Now you can leave them and join from the start of new room.

[williamkray]

hmmm. ok, i guess that makes sense, it's just contrary to how element handles it but i'll run with it for a bit.

[williamkray]

ah, i just left my test room, and then clicked the button to "Join old room" to see it, and i cannot because it was invite-only. so there's no way to regain access to any data in that room this way.

[williamkray]

i guess i expect the behavior to align more closely to the "recommended" behavior of the spec:

Clients which understand m.room.tombstone events and the predecessor field on m.room.create events should communicate to the user that the room was upgraded. One way of accomplishing this would be hiding the old room from the user’s room list and showing banners linking between the old and new room - ensuring that permalinks work when referencing the old room. Another approach may be to virtually merge the rooms such that the old room’s timeline seamlessly continues into the new timeline without the user having to jump between the rooms.