Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unencrypted messages in encrypted rooms are not indicated #1127

Open
notramo opened this issue Feb 18, 2023 · 7 comments
Open

Unencrypted messages in encrypted rooms are not indicated #1127

notramo opened this issue Feb 18, 2023 · 7 comments

Comments

@notramo
Copy link

notramo commented Feb 18, 2023

Describe the bug

No indicator next to unencrypted messages in encrypted rooms.

Reproduction

Send an unencrypted message in an encrypted room.

Expected behavior

Red explanation mark, shield, stop sign, or anything indicating a warning.

Platform and versions

All platforms affected.

Additional context

No response

@LinuxinaBit
Copy link

LinuxinaBit commented Feb 27, 2023

This seems to basically be the same as your other issue, #1128 , as an encryption indicator for the entire room would indicate weather a message was encrypted, correct?
You can’t really have an unencrypted message in an encrypted room, or an encrypted message in an unencrypted room…
An encryption indicator next to each message would also add a significant amount of clutter.
I’d close this issue in favor of #1128 , but that’s up to you.

@notramo
Copy link
Author

notramo commented Feb 27, 2023

An encryption indicator for the entire room doesn't indicate individual messages sent from clients that doesn't support encryption (or support but accidentally turned it off).

@LinuxinaBit
Copy link

Can unencrypted clients even join an encrypted room?
I didn’t know that was a thing.
In that case, an indicator on unencrypted messages only in encrypted rooms is the best UX.

@notramo
Copy link
Author

notramo commented Mar 1, 2023

They can join, just won't be able to read any messages.

@LinuxinaBit
Copy link

Ah, that’s interesting
It shouldn’t matter to anyone but the unencrypted user though, as you said, they can’t see your messages, so you don’t have to worry about them being unencrypted, and they already know they’re unencrypted because of the unreadable messages…

@notramo
Copy link
Author

notramo commented Mar 4, 2023

It should matter as it's unencrypted data in an encrypted communication. It doesn't matter if it makes sense or not, or if the conversation can be trusted or not. It's unencrypted, so it should be indicated.

One dangerous use case is that e.g. a sysadmin sets up a bot, that reports some system info to a Matrix room, but they forget to configure the encryption in the bot config. The bot then continues to send unencrypted (possibly sensitive) data to the Matrix room, with no way for the user to tell it if they only use Cinny.

@LinuxinaBit
Copy link

Ah, makes some sense…
Just rename the Issue to “Unencrypted Messages in Encrypted Rooms Not Indicated”, and the other Issue to “Unencrypted Rooms Not Indicated” to avoid confusion please.
Thanks, and sorry for the misunderstandings :)

@notramo notramo changed the title Unencrypted messages are not indicated. Unencrypted messages in encrypted rooms are not indicated Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants