chore: clean up test suite per audit recommendations

Executes recommendations from a comprehensive test suite audit.
Removes dead, redundant, and trivial tests; rewrites SessionDetail
polling test to exercise real gating; trims duplicated assertions;
adds missing assertion in assistant-loading tests.

13 files changed, 233 insertions(+), 462 deletions(-)

Author: chriswritescode-dev

backend/test/bun-mock-test.test.ts

@@ -1,6 +1,5 @@
 import { describe, it, expect, beforeEach, vi } from 'vitest'
 import * as db from '../../src/db/queries'
-import * as schema from '../../src/db/schema'
 
 const mockDb = {
   prepare: vi.fn(),
@@ -289,17 +288,4 @@ describe('Database Queries', () => {
       expect(mockDb.prepare).not.toHaveBeenCalled()
     })
   })
-
-  describe('Database Schema', () => {
-    it('should have schema module available', () => {
-      expect(schema.initializeDatabase).toBeDefined()
-      expect(typeof schema.initializeDatabase).toBe('function')
-    })
-  })
-
-  describe('Transaction Support', () => {
-    it('should support transaction existence', () => {
-      expect(typeof mockDb.transaction).toBe('function')
-    })
-  })
 })

backend/test/db/queries.test.ts

@@ -72,13 +72,6 @@ describe('STT Routes', () => {
     sttApp = createSTTRoutes(mockDb)
   })
 
-  describe('createSTTRoutes', () => {
-    it('should create a Hono app with routes', () => {
-      expect(sttApp).toBeDefined()
-      expect(typeof sttApp.fetch).toBe('function')
-    })
-  })
-
   describe('GET /status', () => {
     it('should return status with correct structure', async () => {
       const req = new Request('http://localhost/status?userId=test')

backend/test/routes/sse.test.ts

@@ -130,31 +130,6 @@ describe("DialogContent", () => {
     expect(screen.queryByRole("button", { name: /close/i })).not.toBeInTheDocument();
   });
 
-  it("merges custom className with default classes", () => {
-    render(
-      <Dialog open>
-        <DialogContent className="custom-class" data-testid="dialog-content">
-          Content
-        </DialogContent>
-      </Dialog>
-    );
-    const content = screen.getByTestId("dialog-content");
-    expect(content).toHaveClass("custom-class");
-    expect(content).toHaveClass("fixed");
-    expect(content).toHaveClass("z-[70]");
-  });
-
-  it("renders children correctly", () => {
-    render(
-      <Dialog open>
-        <DialogContent>
-          <span>Test Child Content</span>
-        </DialogContent>
-      </Dialog>
-    );
-    expect(screen.getByText("Test Child Content")).toBeInTheDocument();
-  });
-
   it("accepts mobileSwipeToClose prop without breaking rendering", () => {
     const onOpenChange = vi.fn();
     render(

backend/test/routes/stt.test.ts

@@ -3,19 +3,6 @@ import { render, screen } from "@testing-library/react";
 import { PageHeader } from "./page-header";
 
 describe("PageHeader", () => {
-  it("applies pt-safe class for iOS safe area", () => {
-    render(<PageHeader data-testid="header">Content</PageHeader>);
-    const header = screen.getByTestId("header");
-    expect(header).toHaveClass("pt-safe");
-  });
-
-  it("applies sticky top-0 positioning", () => {
-    render(<PageHeader data-testid="header">Content</PageHeader>);
-    const header = screen.getByTestId("header");
-    expect(header).toHaveClass("sticky");
-    expect(header).toHaveClass("top-0");
-  });
-
   it("renders children correctly", () => {
     render(
       <PageHeader>
@@ -24,37 +11,4 @@ describe("PageHeader", () => {
     );
     expect(screen.getByText("Test Child")).toBeInTheDocument();
   });
-
-  it("merges custom className", () => {
-    render(
-      <PageHeader data-testid="header" className="custom-class">
-        Content
-      </PageHeader>
-    );
-    const header = screen.getByTestId("header");
-    expect(header).toHaveClass("custom-class");
-    expect(header).toHaveClass("pt-safe");
-  });
-
-  it("forwards additional props", () => {
-    render(
-      <PageHeader data-testid="header" aria-label="Page header">
-        Content
-      </PageHeader>
-    );
-    const header = screen.getByTestId("header");
-    expect(header).toHaveAttribute("aria-label", "Page header");
-  });
-
-  it("applies z-10 for proper stacking", () => {
-    render(<PageHeader data-testid="header">Content</PageHeader>);
-    const header = screen.getByTestId("header");
-    expect(header).toHaveClass("z-10");
-  });
-
-  it("applies transparent background", () => {
-    render(<PageHeader data-testid="header">Content</PageHeader>);
-    const header = screen.getByTestId("header");
-    expect(header).toHaveClass("bg-transparent");
-  });
 });

frontend/src/components/ui/dialog.test.tsx

@@ -48,46 +48,6 @@ describe('SideDrawer', () => {
     expect(handleClose).toHaveBeenCalled()
   })
 
-  it('applies pt-safe and pb-safe classes', () => {
-    render(
-      <SideDrawer isOpen onClose={() => {}} ariaLabel="Test drawer">
-        <div>Test content</div>
-      </SideDrawer>,
-    )
-    const dialog = document.querySelector('[role="dialog"]')
-    expect(dialog).toHaveClass('pt-safe')
-    expect(dialog).toHaveClass('pb-safe')
-  })
-
-  it('defaults to right side', () => {
-    render(
-      <SideDrawer isOpen onClose={() => {}} ariaLabel="Test drawer">
-        <div>Test content</div>
-      </SideDrawer>,
-    )
-    const dialog = document.querySelector('[role="dialog"]')
-    expect(dialog).toHaveClass('right-0')
-  })
-
-  it('applies left side when specified', () => {
-    render(
-      <SideDrawer isOpen onClose={() => {}} side="left" ariaLabel="Test drawer">
-        <div>Test content</div>
-      </SideDrawer>,
-    )
-    const dialog = document.querySelector('[role="dialog"]')
-    expect(dialog).toHaveClass('left-0')
-  })
-
-  it('applies custom widthClass', () => {
-    render(
-      <SideDrawer isOpen onClose={() => {}} widthClass="w-80" ariaLabel="Test drawer">
-        <div>Test content</div>
-      </SideDrawer>,
-    )
-    const dialog = document.querySelector('[role="dialog"]')
-    expect(dialog).toHaveClass('w-80')
-  })
 })
 
 describe('SideDrawerHeader', () => {
@@ -119,14 +79,4 @@ describe('SideDrawerContent', () => {
     )
     expect(screen.getByText('Content')).toBeInTheDocument()
   })
-
-  it('applies custom className', () => {
-    render(
-      <SideDrawerContent className="custom-class">
-        <div>Content</div>
-      </SideDrawerContent>,
-    )
-    const content = screen.getByText('Content').parentElement
-    expect(content).toHaveClass('custom-class')
-  })
 })

frontend/src/components/ui/page-header.test.tsx

@@ -52,9 +52,6 @@ describe('useScheduleTarget', () => {
       })
 
       expect(result.current.scheduleTarget?.kind).toBe('assistant')
-      expect(result.current.scheduleTarget?.fullPath).toBe('/abs/assistant')
-      expect(result.current.scheduleTarget?.repoId).toBe(0)
-      expect(result.current.scheduleTarget?.backHref).toBe('/assistant')
       expect(result.current.isLoading).toBe(false)
       expect(result.current.isError).toBe(false)
     })
@@ -98,9 +95,6 @@ describe('useScheduleTarget', () => {
       })
 
       expect(result.current.scheduleTarget?.kind).toBe('repo')
-      expect(result.current.scheduleTarget?.repoId).toBe(5)
-      expect(result.current.scheduleTarget?.fullPath).toBe('/abs/repos/my-repo')
-      expect(result.current.scheduleTarget?.backHref).toBe('/repos/5')
     })
 
     it('does not call getAssistantModeStatus for repo', async () => {

frontend/src/components/ui/side-drawer.test.tsx

@@ -137,52 +137,6 @@ describe('useLSPStatus', () => {
     expect(result.current.error).toBeTruthy()
   })
 
-  it('should have 30s refetch interval', async () => {
-    mockGetLSPStatus.mockResolvedValue([])
-    vi.mocked(useOpenCodeClient).mockReturnValue(mockClient)
-
-    const queryClient = new QueryClient({
-      defaultOptions: { queries: { retry: false } }
-    })
-    const wrapper = ({ children }: { children: React.ReactNode }) => (
-      <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
-    )
-
-    const { result } = renderHook(() => useLSPStatus('http://localhost:5551', '/test'), {
-      wrapper
-    })
-
-    await waitFor(() => {
-      expect(result.current.isSuccess).toBe(true)
-    })
-
-    const observer = queryClient.getQueryCache().find({ queryKey: ['opencode', 'lsp', 'http://localhost:5551', '/test'] })
-    expect((observer?.options as any).refetchInterval).toBe(30000)
-  })
-
-  it('should have 10s stale time', async () => {
-    mockGetLSPStatus.mockResolvedValue([])
-    vi.mocked(useOpenCodeClient).mockReturnValue(mockClient)
-
-    const queryClient = new QueryClient({
-      defaultOptions: { queries: { retry: false } }
-    })
-    const wrapper = ({ children }: { children: React.ReactNode }) => (
-      <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
-    )
-
-    const { result } = renderHook(() => useLSPStatus('http://localhost:5551', '/test'), {
-      wrapper
-    })
-
-    await waitFor(() => {
-      expect(result.current.isSuccess).toBe(true)
-    })
-
-    const observer = queryClient.getQueryCache().find({ queryKey: ['opencode', 'lsp', 'http://localhost:5551', '/test'] })
-    expect((observer?.options as any).staleTime).toBe(10000)
-  })
-
   it('should refetch on window focus', async () => {
     mockGetLSPStatus.mockResolvedValue([])
     vi.mocked(useOpenCodeClient).mockReturnValue(mockClient)

frontend/src/hooks/__tests__/useScheduleTarget.test.tsx

@@ -264,10 +264,10 @@ describe('SessionDetail assistant loading at repoId=0', () => {
     })
   })
 
-  it('renders "Assistant" as workspaceDisplayName for non-assistant sessions without repo', async () => {
+  it('shows the loading state for a non-assistant session whose repo has not loaded', async () => {
     mocks.useSession.mockReturnValue({ data: undefined, isLoading: false })
 
-    return render(
+    render(
       <MemoryRouter initialEntries={['/repos/1/sessions/sess-1']}>
         <QueryClientProvider client={createQueryClient()}>
           <Routes>
@@ -276,5 +276,9 @@ describe('SessionDetail assistant loading at repoId=0', () => {
         </QueryClientProvider>
       </MemoryRouter>
     )
+
+    await waitFor(() => {
+      expect(screen.getByText('Loading repository...')).toBeInTheDocument()
+    })
   })
 })