Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easywave SYCL performance #1

Open
jgtong opened this issue Sep 14, 2023 · 3 comments
Open

easywave SYCL performance #1

jgtong opened this issue Sep 14, 2023 · 3 comments

Comments

@jgtong
Copy link

jgtong commented Sep 14, 2023

Greetings @christgau

I am wondering if I can make a contribution or code changes to your easywave-sycl version? We have a performant easywave-SYCL version from our Velocity Bench, which we removed the DPCT functions, especially the low performing 2-D memcpy function. The functionality between the two versions are the same.

@christgau
Copy link
Owner

@jgtong. Sure, contributions are welcome. Just provide a PR and I will take a look at it.

@jgtong
Copy link
Author

jgtong commented Sep 19, 2023

@christgau : May I have push access to this repo? It says that I do not have permission

@christgau
Copy link
Owner

That's right, because that's different from creating a pull request if I understand you correctly.

From my point of view: Please create a fork first if you haven't done yet and then create a PR to this repo. Direct push (into master/main) is not the (my) preferred way to "merge" contrbutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants