Skip to content

Commit 9c17fca

Browse files
committed
msglist [nfc]: Pull out asserts that also apply at start of new block
1 parent 359b99a commit 9c17fca

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

lib/model/message_list.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -452,14 +452,15 @@ mixin _MessageSequence {
452452
items.add(MessageListRecipientHeaderItem(message));
453453
canShareSender = false;
454454
} else {
455+
assert(items.last is MessageListMessageBaseItem);
456+
final prevMessageItem = items.last as MessageListMessageBaseItem;
457+
assert(identical(prevMessageItem.message, prevMessage));
458+
assert(prevMessageItem.isLastInBlock); // though this may mutate; see below
459+
455460
if (oneMessagePerBlock || !haveSameRecipient(prevMessage, message)) {
456461
items.add(MessageListRecipientHeaderItem(message));
457462
canShareSender = false;
458463
} else {
459-
assert(items.last is MessageListMessageBaseItem);
460-
final prevMessageItem = items.last as MessageListMessageBaseItem;
461-
assert(identical(prevMessageItem.message, prevMessage));
462-
assert(prevMessageItem.isLastInBlock);
463464
prevMessageItem.isLastInBlock = false;
464465

465466
if (!messagesSameDay(prevMessageItem.message, message)) {

0 commit comments

Comments
 (0)