execution_wrapper.exe removed from openvox agent 8.23.1

[magarvo]

Hi,

The execution_wrapper.exe looks to be missing from the openvox agent release as per the PR OpenVoxProject/openvox-agent#101

It looks to be replaced with a simple Ruby file named execution_wrapper. Can this be also used for Windows?

Thanks

[ripienaar]

It could be, you might try patching a dev machine to see if it works then send a PR? I think it might, Choria also now has its own kind of similar thing but that is a bit more work to integrate

[magarvo]

I patched it to use the execution_wrapper file and it fails on the File.executable?(wrapper_path) check

choria-mcorpc-support/lib/mcollective/util/tasks_support.rb

Line 62 in b48e070

File.exist?(wrapper_path) && File.executable?(wrapper_path)

Removing that check then gives the following:

E, [2025-10-02T18:49:40.552720 #10008] ERROR -- : agent.rb:102:in rescue in handlemsg' bolt_tasks#run_and_wait failed: Errno::ENOEXEC: Exec format error - C:\Program Files\Puppet Labs\Puppet\puppet\bin/execution_wrapper E, [2025-10-02T18:49:40.552874 #10008] ERROR -- : agent.rb:103:in rescue in handlemsg' C:/Program Files/Puppet Labs/Puppet/puppet/lib/ruby/gems/3.2.0/gems/choria-mcorpc-support-2.26.4/lib/mcollective/util/tasks_support.rb:316:in spawn' C:/Program Files/Puppet Labs/Puppet/puppet/lib/ruby/gems/3.2.0/gems/choria-mcorpc-support-2.26.4/lib/mcollective/util/tasks_support.rb:316:in spawn_command'
C:/Program Files/Puppet Labs/Puppet/puppet/lib/ruby/gems/3.2.0/gems/choria-mcorpc-support-2.26.4/lib/mcollective/util/tasks_support.rb:401:in `run_task_command'

Not sure how to get it to execute.

[ripienaar]

When you just run that file on its own in your cmd.exe does it work? I think probably this would need to invoke ruby, a bit like this template would once all the paths to ruby etc was expanded

https://github.com/choria-io/puppet-choria/blob/main/templates/choria_mcollective_agent_compat.bat.epp

[magarvo]

It doesn't seem to work running through cmd.exe. The execution_wrapper file seems to be a ruby script with a linux style hashbang: #!/usr/bin/env ruby

Also tried specifying the ruby exe with the script with no success:

ruby_exe = 'C:\Program Files\Puppet Labs\Puppet\puppet\bin\ruby.exe'
command = "C:\Program Files\Puppet Labs\Puppet\puppet\bin\execution_wrapper"
command = ruby_exe + " " + command
pid = Process.spawn(environment, [command, command], options)

Errno::EINVAL: Invalid argument - C:\Program Files\Puppet Labs\Puppet\puppet\bin\ruby.exe C:\Program Files\Puppet Labs\Puppet\puppet\bin\execution_wrapper

https://github.com/OpenVoxProject/openvox/blob/main/packaging/resources/files/execution_wrapper

[ripienaar]

Yes so what I am showing is how you'd make a batch file to run the ruby wrapper. You'll find some already installed by choria module to copy from also like choria_mcollective_agent_compat.bat, you need one of those

[magarvo]

I get you now. I made a batch file like this:

"C:\Program Files\Puppet Labs\Puppet\puppet\bin\ruby.exe" "C:\Program Files\Puppet Labs\Puppet\puppet\bin\execution_wrapper"

This worked! I'll see about putting it into a template format tomorrow, long day. Many thanks

[magarvo]

Heres the PR to handle the execution_wrapper.bat file.
#215

Also the PR for Openvox to add execution_wrapper.bat.
OpenVoxProject/openvox#222

[ripienaar]

OK, lets wait for that to be merged then before merging this one - thank you

[magarvo]

Theres another issue where it uses PowershellShim.ps1 which doesnt exist anymore. Bypassing that and running it through the execution_wrapper directly results in the powershell script arguments being passed through stdin. Is that an ideal behaviour?

[ripienaar]

Unfortunately not sure what powershell needs - but doesn't sound good no

[magarvo]

Is it worth waiting for the Choria implementation instead of patching this up? I added the workarounds into my own environment, I'd be happy to wait.

[ripienaar]

If you can get the script approach working that will be fatest. Rather than wait for openvox we can add it here like the others.