Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running @ngx-env/builder with Angular 19 and Karma #113

Closed
iiceman40 opened this issue Nov 29, 2024 · 5 comments
Closed

Running @ngx-env/builder with Angular 19 and Karma #113

iiceman40 opened this issue Nov 29, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@iiceman40
Copy link

iiceman40 commented Nov 29, 2024

Hi,

I updated to Angular 19.0.1 and @ngx-env/builder to 19.0.2 today and got everything working... until I tried to run my tests. I then got this error:

@ngx-env/builder: Karma builder is not supported yet due to a limitation in the Angular CLI, use jest instead

I checked the documentation and found this line:

Supports all Angular CLI commands (Karma is not supported on v19)

So I am wondering now if this is the final state or if I can expect things to work in a later version. Maybe someone can elaborate why this doesn't work anymore. Since Karama is still the default test runner even for Angular 19, I somehow expect this to work 😅

Do I really have to stop using Karma or dotenv-run to get my tests to run or should I just give it a bit time and wait for a later version where this might work again?

@chihab
Copy link
Owner

chihab commented Nov 29, 2024

Hi, good question.

Short answer, wait for a later version where this might work again :)

I'll have a look over the weekend to see if Angular CLI plans to support this (may need to open an issue on their repo) or alternatively have a workaround (back to the old way if possible).

@chihab chihab added the enhancement New feature or request label Nov 30, 2024
@chihab
Copy link
Owner

chihab commented Dec 1, 2024

Opened an issue here: angular/angular-cli#29003

Update: the issue has been labelled as a bug so we can expect a fix.

@iiceman40
Copy link
Author

Great, thank you! 😊 👍

@chihab
Copy link
Owner

chihab commented Dec 15, 2024

Should be working now with latest versions of Angular and @ngx-env/builder.

@iiceman40
Copy link
Author

I got to try it again today and everything seems fine now. Thank you! 🙏 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants