Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

野火系统内置样式覆盖highlightjs样式 #30

Open
tim-gao opened this issue Feb 11, 2018 · 2 comments
Open

野火系统内置样式覆盖highlightjs样式 #30

tim-gao opened this issue Feb 11, 2018 · 2 comments

Comments

@tim-gao
Copy link

tim-gao commented Feb 11, 2018

问题描述 Issue Description

添加野火评论系统后,由于野火加载在最后并且内置的style重新定制了标签的样式。所以如果你想使用highlightJS定制你的代码样式时,会碰到原highlightjs样式被野火内置样式覆盖的问题。

[讲讲问题是什么。]
[Tell us about the issue.]

如何重现 Reproduce

  1. 在网站使用野火评论系统,配置theme:'light'

  2. 在网站引入highlightjs并导入主题样式,如agate.css

  3. 刷新网页, agate主题样式会被覆盖

@cheng-kang
Copy link
Owner

@tim-gao 感谢提出 issue。

CSS 污染的问题我们正在处理,https://github.com/cheng-kang/wildfire/pull/29,这个 PR 中新增了“以 iframe 形式添加 wildfire 评论”的功能,正在进行内部审查和改进。会在下一个正式版本中发布。

如果有需要的话,我们也可以先发布一个测试版,但是因为新版本涉及到其他内容的改动,所以切换到测试版以及将来切换回正式版的过程可能出现一些麻烦。建议修改一下 agate.css 源码,给被污染的 CSS 加上 !important,临时解决一下问题。

新版本发布后会在这里进行提醒。

@cheng-kang cheng-kang added this to the wildfire with iframe milestone Feb 11, 2018
@tim-gao
Copy link
Author

tim-gao commented Feb 12, 2018

感谢,我会关注的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants