Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File verifier used without %{path} #896

Open
lamont-granquist opened this issue Sep 1, 2021 · 0 comments
Open

File verifier used without %{path} #896

lamont-granquist opened this issue Sep 1, 2021 · 0 comments
Labels
New Cop Proposal A proposal for a new Cookstyle cop Status: Untriaged An issue that has yet to be triaged.

Comments

@lamont-granquist
Copy link
Contributor

For file/template/cookbook_file/remote_file

The verifier should have the path of the tempfile:

# good
verify 'nginx -t -c %{path}'

Pretty sure if you leave it off that's always a bug and probably will validate the old config rather than the new or some kind of nonsense:

# bad
verify 'nginx -t'

Cannot be autocorrected because we can't guess what the right command is.

@lamont-granquist lamont-granquist added Status: Untriaged An issue that has yet to be triaged. New Cop Proposal A proposal for a new Cookstyle cop labels Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Cop Proposal A proposal for a new Cookstyle cop Status: Untriaged An issue that has yet to be triaged.
Projects
None yet
Development

No branches or pull requests

1 participant