Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef/Deprecations cop to detect use of Built-in Cookbooks #860

Open
1 of 7 tasks
Swathisivakumar opened this issue Jun 10, 2021 · 4 comments
Open
1 of 7 tasks

Chef/Deprecations cop to detect use of Built-in Cookbooks #860

Swathisivakumar opened this issue Jun 10, 2021 · 4 comments
Labels
New Cop Proposal A proposal for a new Cookstyle cop Status: Untriaged An issue that has yet to be triaged.

Comments

@Swathisivakumar
Copy link

Swathisivakumar commented Jun 10, 2021

What category of cop is this?:

Please try to select as few as possible.

  • Chef/Deprecations - A cop that alerts on a deprecation in the Chef Infra Client
  • Chef/Correctness - A cop that alerts when incorrect coding behavior is being used
  • Chef/Sharing - A cop that alerts to missing functionality necessary for sharing cookbooks with others
  • Chef/Style - A cop that alerts to a style best practice
  • Chef/Modernize - A cop that alerts when a cookbook can be simplified or modernized with new functionality
  • Chef/Effortless - A cop that alerts on code that must be resolved to move to the Effortless pattern
  • Chef/RedundantCode - A cop that detects redundant code regardless of Chef Infra release

Describe the new cop:

This is a request for cookstyle to detect the now native cookbook that are merged into chef core but still being used in the policyfile.rb, runlist or metadata.rb

What it would trigger on:

cookbook 'built-in-cookbook', '~> *'
            or
run_list ['built-in-cookbook']
@Swathisivakumar Swathisivakumar added New Cop Proposal A proposal for a new Cookstyle cop Status: Untriaged An issue that has yet to be triaged. labels Jun 10, 2021
@Swathisivakumar Swathisivakumar changed the title Chef/Deprecations cop to detect use of poise-hoist in Cookbooks Chef/Deprecations cop to detect use of Built-in Cookbooks Jun 10, 2021
@tas50
Copy link
Contributor

tas50 commented Aug 18, 2021

@Swathisivakumar Is there a particular cookbook you're looking to detect that we're not currently flagging?

@tas50
Copy link
Contributor

tas50 commented Aug 18, 2021

#884 probably covers all the cookbooks you'd be interested in.

@tas50
Copy link
Contributor

tas50 commented Aug 18, 2021

#886 includes another set of old cookbooks

@Swathisivakumar
Copy link
Author

@tas50 , We were hoping that Chef had the whole list :)

The other two we are aware of that we really want to check is poise-hoist and chef-client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Cop Proposal A proposal for a new Cookstyle cop Status: Untriaged An issue that has yet to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants