incorrect check in history status

[rishichawda]

Thanks @cmailank for reporting this.

Describe the bug

The client run status for the previous day seems to be missing if the run happened within 24 hours from now. As we can see it reports check in for only today while there was a client run yesterday and another one today. So we would expect 2 icons in the time series. Based on the UI, a user would expect that "Today" is 00:00Hrs to now.

Even in the infrastructure dashboard it clearly shows the client runs are from different days.

To Reproduce

Steps to reproduce the behavior:

• Chef client run on X date.
• Chef client run on the next day after X but within 24 hour period of the client run on X date.

Expected behavior

A user would expect the status data to be separated based on local time.

Versions (please complete the following information):

• OS: [e.g. rhel6] any
• Browser [e.g. chrome, safari] any
• Automate Build Number: 20220223121207

Additional context

I took the liberty to look into it further and it seems like the request to node_runs_daily_status_time_series is returning something like this. Which tells us that the most recent status was 24hours back from now rather than 00:00Hrs to now for today.

Which is also confirmed by the function at

automate/components/config-mgmt-service/grpcserver/cfg_mgmt.go

Line 157 in f4b4aa2

func (s *CfgMgmtServer) GetNodeRunsDailyStatusTimeSeries(ctx context.Context,

which uses the utility function

automate/components/config-mgmt-service/grpcserver/cfg_mgmt.go

Lines 565 to 573 in f4b4aa2

	func calculateStartEndCheckInTimeSeries(daysAgo int32) (time.Time, time.Time) {
	now := time.Now()
	endTime := time.Date(now.Year(), now.Month(), now.Day(),
	now.Hour(), 0, 0, 0, time.UTC).Add(time.Hour)
	startTime := endTime.Add(-time.Hour * 24 * time.Duration(daysAgo))
	return startTime, endTime
	}

that is written in such a way that it calculates X*24 hours ago from when the request was made to the server with UTC time.

[rishichawda]

On a side note, the infrastructure tab shows the client run timings in UTC - it should be localised. As a user I would probably be interested in seeing times in my local time zone.