Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Bubble timeline on Akkoma and Chuckya #858

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Steffo99
Copy link
Contributor

@Steffo99 Steffo99 commented Oct 5, 2024

Closes #601.

Still very work in progress, but wanted to share it in the meantime!

To do

  • allow the timeline to be picked in the multi-column view
  • check whether the bubble timeline is supported by a given Akkoma instance

Screenshot

Not really necessary, but all pull requests look nicer with images!

@Steffo99 Steffo99 changed the title Initial support for Akkoma's bubble timeline Support for Bubble timeline on instance where it is available Oct 11, 2024
@Steffo99 Steffo99 changed the title Support for Bubble timeline on instance where it is available Support for Bubble timeline on instances where it is available Oct 11, 2024
@Steffo99
Copy link
Contributor Author

Figured out how to add it to the shortcut menu, but I'm struggling to understand how to add a new input type to the shortcut settings (the "variant" option would need a <select>).

For now I've set its type to "text", and I'm having the user input the string corresponding to the chosen variant manually.

More screenshots!

@cheeaun cheeaun added enhancement New feature or request akkoma labels Oct 14, 2024
@Steffo99 Steffo99 force-pushed the feature/akkoma-bubble branch from 3727666 to ae9330a Compare December 9, 2024 03:13
@Steffo99 Steffo99 changed the title Support for Bubble timeline on instances where it is available Support for Bubble timeline on Akkoma and Chuckya Dec 9, 2024
The `text` variable wasn't passing through Lingui, despite being a `msg`.
@Steffo99
Copy link
Contributor Author

Steffo99 commented Dec 9, 2024

This works everywhere now, and even has a proper dropdown:

I think I also stumbled upon a bug in the import of shortcuts, which I think I fixed in 369935f.

@Steffo99 Steffo99 marked this pull request as ready for review December 9, 2024 04:24
@Steffo99
Copy link
Contributor Author

Steffo99 commented Dec 9, 2024

CCing @TheEssem, who might (or might not) be interested in this implementation, as author of TheEssem/mastodon@07ff6d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akkoma enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Akkoma Bubble Support
2 participants