Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the tests more robust #1

Open
chatman opened this issue Jan 29, 2016 · 1 comment
Open

Making the tests more robust #1

chatman opened this issue Jan 29, 2016 · 1 comment

Comments

@chatman
Copy link
Owner

chatman commented Jan 29, 2016

  1. Instead of waiting 10sec, check the list of live nodes from ZK (/live_nodes znode). You can use the CloudSolrClient's ZK client to check for the cluster state / live nodes.
  2. When any command terminates with error (exit code != 0), then don't perform further steps and exit your test with non-0 error code (System.exit(errorCode));
  3. Start ZK from the test itself, and on a random port.
  4. Use random directory names and random port numbers every time.
  5. If there's a success, stop zk, solr and clean up directories.
  6. If there's a failure, then don't stop ZK or Solr or cleanup, but instead print the port numbers where things are running and the directories (so that user can manually check the logs in those directories).
@viveknarang
Copy link
Collaborator

Agree Ishan !!! Working on them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants