Upgrade all dependencies #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-conn. Since Carmine v2.0.0, the functions with-conn, make-conn-pool and make-conn-spec were deprecated. This commit changes library to use wcar instead. See [the Carmine CHANGELOG][1] for details on this change. [1]: https://github.com/ptaoussanis/carmine/blob/master/CHANGELOG.md#v1120--v200
|
Can you look at the CI breaks. If that passes, I'll accept. |
|
I’ll look into it. Something to do with the default redis connection. |
|
CI passes. Also, I can take over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I upgraded all dependencies and changed the
create-redis-storefunction to be compatible with the new Carmine API for creating a redis-store.Closes #1