Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make releases of Kibiter #38

Open
dlumbrer opened this issue Oct 30, 2017 · 6 comments
Open

Make releases of Kibiter #38

dlumbrer opened this issue Oct 30, 2017 · 6 comments

Comments

@dlumbrer
Copy link

dlumbrer commented Oct 30, 2017

We want to build ZIP's for each Kibiter version. This could be usefull in order to check new versions or little changes.

Kibana has by default a way to build a tar.gz of the current version that you are, doing:

npm run build

This must create the tars into KIBITER_HOME/target/, one tar for each OS. However, this command generates an error and it's impossible to continue, so we just add this option in order to avoid that error:

npm run build -- --skip-os-packages

Now, tars have been built and are in KIBITER_HOME/target/.

Important: That command don't copy the plugins don't into the plugins/ folder of the tars, so it's needed to add this line into a grunt configurations file (before the tar creation):

  • In KIBITER_HOME/tasks/build/archives.js:
async function archives({ name, buildName, zipPath, tarPath }) {
   ...
   await exec('cp', ['-rf', fromRoot("plugins/"), fromRoot("build/" + buildName + "/.")]); //This line
   await exec('tar', tarArguments);
}
@jgbarah
Copy link

jgbarah commented Nov 4, 2017

I see the first of this releases uploaded to the releases area of this repo. Thanks! Some comments about it:

  • There is only a tar.gz for Linux. Is it possible / simple to have installable files for other architectures as well?
  • The directory where it unpacks is kibana-5.6.0-SNAPSHOT-linux-x86_64. Could it be something like kibiter-5.6.0-1-linux-x86_64 (assuming that "1" means the first release of Kibiter based on Kibana 5.6.0). That way it will be more clear what yoù´ re installing.
  • The name of the file now is kibiter-5.6.0-linux-x86_64.tar.gz. For the same reasons as above, could it be kibiter-5.6.0-1-linux-x86_64.tar.gz?

@dlumbrer
Copy link
Author

dlumbrer commented Nov 6, 2017

@jgbarah These are the solutions that I propose:

  • This is not a problem, when run npm run build -- --skip-os-packages a build of each SO is created.
  • I can change a few params in grunt archives in order to change the name and add a new tag "version" that starts with 1.

I'm going to build and add the updated releases!

@jgbarah
Copy link

jgbarah commented Nov 6, 2017

I think this is perfect, thanks!!

I suggest that you write down the process for a release in a file RELEASING.md or something like that, so that everything is clear. But we can use a pull request for that, and close this ticket if you want.

@acs
Copy link
Member

acs commented Jul 18, 2018

I am rechecking now the full process for 6.3.1 ... it seems to be pretty similar, but the way to create now the release tar balls is:

acs@~/devel/grimoirelab-kibiter-fork-acs (venv) [integration-6.3.1-nobrand] $ node scripts/build --oss --skip-os-packages --release

Stay tuned!

@acs
Copy link
Member

acs commented Jul 18, 2018

The changes needed to include the plugins in the release file, and to change the name of the release file:
acs@551e0db

@dlumbrer
Copy link
Author

For Kibiter 6.8.6 the command has changed a little:

node scripts/build --oss --skip-os-packages --release --all-platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants