[enrich] Update decorator to add metadeta only for non-empty items

[animeshk08]

The decorator present in the below method adds metadata to the enriched item even if the item is empty

grimoirelab-elk/grimoire_elk/enriched/enrich.py

Line 84 in 48486d0

def metadata(func):

An empty item may be generated in case the item does not belong to a category that is to be enriched. For e.g in case, the item does not belong to 'issues', 'pull requests' or 'repositories' in the case of github2 enricher.

grimoirelab-elk/grimoire_elk/enriched/github2.py

Line 219 in 48486d0

def get_rich_item(self, item):

An update is also needed here to upload only non-empty documents:

grimoirelab-elk/grimoire_elk/enriched/github2.py

Line 389 in 48486d0

items_to_enrich.append(eitem)

[animeshk08]

Proposed solution:

• Add the below check to
  

  grimoirelab-elk/grimoire_elk/enriched/enrich.py

  Line 93 in 48486d0

  eitem = func(self, *args, **kwargs)

   eitem = func(self, *args, **kwargs)
 + if not eitem:
 +          return eitem

• Add a check to skip uploading of empty documents in the enrich_items method. A continue statement can be added here:
  

  grimoirelab-elk/grimoire_elk/enriched/enrich.py

  Line 390 in 578b494

  rich_item = self.get_rich_item(item)

- rich_item = self.get_rich_item(item)
+ if not rich_item:
+       continue

• Add a check the enricher for backends which override the enrich_items method e.g. in :
  

  grimoirelab-elk/grimoire_elk/enriched/github2.py

  Line 389 in 48486d0

  items_to_enrich.append(eitem)

  eitem = self.get_rich_item(item)
- items_to_enrich.append(eitem)
+ if eitem:
+       items_to_enrich.append(eitem)

[animeshk08]

Hi, @valeriocos. Let me know if it looks good to you :)

[valeriocos]

Hi @animeshk08 , your solution looks good, however I don't know if these changes may have side effects. I understand that they shouldn't, but I'm not sure.

[animeshk08]

Okay, Let me know how we should move ahead.

I understand that they shouldn't, but I'm not sure.

I think the same.

[valeriocos]

@animeshk08 , can you prepare a pull request with the suggested changes. I'll perform with it some long-execution tests. Thanks!

[animeshk08]

Thanks. I am on it!!