Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor InputCheckbox and InputRadio icons #903

Open
masoudmanson opened this issue Nov 23, 2024 · 0 comments · May be fixed by #904
Open

Refactor InputCheckbox and InputRadio icons #903

masoudmanson opened this issue Nov 23, 2024 · 0 comments · May be fixed by #904
Assignees
Labels
Bug Something isn't working Feature Request P0 Ready for review This PR is ready for review

Comments

@masoudmanson
Copy link
Contributor

The current SDS control icons need to be updated to use JSX elements with the new Check icon. The issue with the current implementation is that the checked checkbox is hollow, allowing the background color to show through. This causes design inconsistencies when the checkbox is placed on backgrounds other than white (in light mode) or black (in dark mode).

To resolve this, the checkbox design should be updated to feature a solid filled square with the Check icon overlayed on top. The icon’s color should dynamically adjust based on the theme to ensure consistency across different background colors.

The same changes are needed for the InputRadio component.

@masoudmanson masoudmanson self-assigned this Nov 23, 2024
@masoudmanson masoudmanson added Bug Something isn't working Work in Progress This PR is a work in progress P0 Feature Request labels Nov 23, 2024
@masoudmanson masoudmanson linked a pull request Nov 23, 2024 that will close this issue
7 tasks
@masoudmanson masoudmanson linked a pull request Nov 23, 2024 that will close this issue
7 tasks
@masoudmanson masoudmanson added Ready for review This PR is ready for review and removed Work in Progress This PR is a work in progress labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Feature Request P0 Ready for review This PR is ready for review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant