Chakra failed when build with std:c++latest by msvc on Windows

[215020267]

Chakra failed when build with std:c++latest by msvc on Windows. Could you please help take a look at this?

You can repro this issue as the steps below:

1. git clone -c core.autocrlf=true https://github.com/microsoft/ChakraCore D:\Chakra\src
2. open a clean VS2019 x86 prompt and browse to D:\Chakra\src
3. set CL=/std:c++latest
4. msbuild /m /p:Platform=x86 /p:Configuration=Test /p:WindowsTargetPlatformVersion=10.0.18362.0 Build\Chakra.Core.sln /t:Rebuild

Failures:
JsrtContextCore.i
JsrtContextCore.i(1558483): error C2220: the following warning is treated as an error
JsrtContextCore.i(1558483): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)
JsrtContextCore.i(1558485): warning C4499: 'static an explicit specialization cannot have a storage class (ignored)
JsrtContextCore.i(1558487): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)

[rhuanjl]

Hmm - I don't have a setup with the latest msvc to test on.

Does this commit fix the issue: 0fe1f2c

At a glance this appears to relate to how the JsrtContextCore class extends and in some places overwrites parts of the JsrtContext class - as an aside this highlights a refactoring opportunity; we should probably combine these two classes as the difference is historic and not functional.

(JsrtContextCore is components not included in ChakraFull/chakra.dll)

[215020267]

Thanks for your solution. I updated my source. It failed remain. Could you please help take again? I attached ".i" file.
RuntimeMathPch.zip

[rhuanjl]

Thanks for your solution. I updated my source. It failed remain. Could you please help take again? I attached ".i" file.
RuntimeMathPch.zip

I can't find the error/warning in that file, is it still the same error as before? Can you point me to the relevant line/section?

[rhuanjl]

I installed VS2019 to look at this a little further. There are several features used in CC's codebase that are deprecated in C++17 or higher so it's not surprising it won't build with C++latest.

We may well seek to fix this in the future but it's not just one line of code to change so not going to be immediate, for now you'll need to use std=C++14 or even C++11 if you want to build it out of the box.

[QuellaZhang]

@rhuanjl sorry for the confusion, same error as before. I attach new repro file: RuntimeByteCodePch.i.txt
This issue cannot be reproduced on the released MSVC, but we can help test once you fix it.

D:>cl /TP /W4 /WX /wd4458 /wd4312 /wd4163 /c /EHsc /std:c++latest /Gz RuntimeByteCodePch.i /d1db161
RuntimeByteCodePch.i
RuntimeByteCodePch.i(1585686): error C2220: the following warning is treated as an error
RuntimeByteCodePch.i(1585686): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)
RuntimeByteCodePch.i(1585688): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)
RuntimeByteCodePch.i(1585690): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)
D:>cl /TP /W4 /WX /wd4458 /wd4312 /wd4163 /c /EHsc /std:c++latest /Gz RuntimeByteCodePch.i
RuntimeByteCodePch.i
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\DynamicProfileInfo.h(645): error C2220: the following warning is treated as an error
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\DynamicProfileInfo.h(645): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\DynamicProfileInfo.h(647): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\DynamicProfileInfo.h(649): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)

[QuellaZhang]

Hello, any updates?

[rhuanjl]

@QuellaZhang I did a slightly more extensive review of the ChakraCore code base - there are several issues you'll run into trying to build with the latest standards, not just the one highlighted here.

Currently ChakraCore has a C++11 codebase, it uses some features deprecated in C++14,17 and 20 in more than one place.

I am happy to review and merge (if appropriate) any PRs to fix such issues, so please open a PR if you'd like to.

(I have too many other changes I'm working on that I need people to review for me to be making any PRs for C++ standards related points at the moment.)